Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for fake URLs #1

Closed
Bhupesh-V opened this issue Jan 25, 2022 · 4 comments · Fixed by #2
Closed

support for fake URLs #1

Bhupesh-V opened this issue Jan 25, 2022 · 4 comments · Fixed by #2

Comments

@Bhupesh-V
Copy link
Contributor

Hey! first of thanks for creating this package ❤️

It would be nice to have support for generating fake URLs (ref: https://github.com/brianvoe/gofakeit#internet)

Let me know if this can be added into the scope for the project, would love to help/contribute

@casvanluijtelaar
Copy link
Owner

Yes, actually! There is an internet module planned since it was also part of the original faker.js library. I just haven't got around to implementing it yet. Of course if you want to contribute I'd love to see it! unfortunatly the original faker.js package is no longer available but here's a gist with the original implementation

@Bhupesh-V
Copy link
Contributor Author

Yes, actually! There is an internet module planned since it was also part of the original faker.js library. I just haven't got around to implementing it yet. Of course if you want to contribute I'd love to see it! unfortunatly the original faker.js package is no longer available but here's a gist with the original implementation

cool I will work around this weekend to share a draft PR, thanks for the gist link

@Bhupesh-V
Copy link
Contributor Author

Hey is it ok if we create a dataset.json to store TLDs, wdyt?
We can use this list of TLDs by IANA https://data.iana.org/TLD/tlds-alpha-by-domain.txt

@casvanluijtelaar
Copy link
Owner

ah yes sorry I forgot to mention that, faker.js used json files for it's localization and datasets. We do something similar. in lib/src/locales you can find all the language specific datasets. and they get converted to dataclasses you can find in lib/src/models. you can fetch localized data using Faker.locale (see other modules for example). if you need to add to the current dataset you need to add it to the data model (models/internet.dart ) and at the least add some english datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants