Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autoscrolling for non standard orientations #13

Merged
merged 5 commits into from Jun 10, 2022

Conversation

casvanluijtelaar
Copy link
Owner

@casvanluijtelaar casvanluijtelaar commented Jun 10, 2022

fixes #9

  • fix auto scroll for different Direction
  • fix auto scroll for reverse scroll

@casvanluijtelaar casvanluijtelaar self-assigned this Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #13 (c4ed573) into master (6a2c590) will decrease coverage by 1.26%.
The diff coverage is 48.57%.

❗ Current head c4ed573 differs from pull request most recent head a55b5e2. Consider uploading reports for the commit a55b5e2 to get more accurate results

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   81.26%   80.00%   -1.27%     
==========================================
  Files           2        2              
  Lines         491      510      +19     
==========================================
+ Hits          399      408       +9     
- Misses         92      102      +10     
Impacted Files Coverage Δ
lib/src/reorderable_grid.dart 80.85% <45.45%> (-1.78%) ⬇️
lib/src/reorderable_grid_view.dart 76.99% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2c590...a55b5e2. Read the comment docs.

@casvanluijtelaar casvanluijtelaar marked this pull request as ready for review June 10, 2022 11:48
@casvanluijtelaar casvanluijtelaar merged commit 4de4eda into master Jun 10, 2022
@casvanluijtelaar casvanluijtelaar deleted the autoscroll_respect_reverse branch June 10, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-scroll does not respect reverse:true
1 participant