Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better clarity around convert settings #151

Closed
PhAzE-Variance opened this issue Apr 7, 2024 · 7 comments
Closed

Better clarity around convert settings #151

PhAzE-Variance opened this issue Apr 7, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@PhAzE-Variance
Copy link

Is your feature request related to a problem? Please describe.
It's difficult to understand the convert settings, since there is a drop down that seemingly doesn't do anything (see attached image).

Describe the solution you'd like
Drop down should be removed, so level 1 defaults to "No Conversion" and when you click the + symbol to add new conversions, it's easier to understand.

Additional context
Attached image shows the button that appears to do nothing and there's no documentation around this.
convert

@PhAzE-Variance PhAzE-Variance added the enhancement New feature or request label Apr 7, 2024
@Casvt
Copy link
Owner

Casvt commented Apr 7, 2024

You select the format and then click the plus button to add it to the preference list.

I agree that it's not perfect, but I couldn't come up with something better. I don't understand the solution that you're proposing. Could you elaborate?

@PhAzE-Variance
Copy link
Author

PhAzE-Variance commented Apr 7, 2024

For sure, I think you shouln't have that drop down at the bottom, just the + to add a new conversion type next to the "no convertion" block. When a user clicks the plus, the new row shows with it's own drop down for the user to select the type.

@Casvt
Copy link
Owner

Casvt commented Apr 8, 2024

I thought about it, and what you're proposing could make it more confusing actually. Because, if I understand it correctly, there would be a + button next to the No Conversion which would toggle the next row which contains the dropdown for the format to be added. But then there needs to be a second + button next to the dropdown that you click to add the format that you've selected. So then you get two + buttons below each other and that's honestly even more confusing.

So what about this:

The 'No Conversion' row is actually a dropdown. If you change the value from 'No Conversion' to a different format, then it gets added to the list and the 'No Conversion' dropdown get's moved down one row and is set back to 'No Conversion'. How does that sound? Then we have not two, not one, but zero buttons. Just a drop down that you can select from and it automatically creates the space to add another one and so on.

@PhAzE-Variance
Copy link
Author

Yeah that works too. Each row would need way to be removed too.

@Casvt
Copy link
Owner

Casvt commented Apr 8, 2024

Yeah but that can be done with the bin icon to the right of each row that already exists

@PhAzE-Variance
Copy link
Author

Sounds nice and clean to me

@Casvt Casvt closed this as completed in b42f1d8 Apr 8, 2024
@Casvt
Copy link
Owner

Casvt commented Apr 8, 2024

Turned out to be a pretty easy fix. See the video:

20240408-1334-51.5621349.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants