Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

error in combination of isRequired and isEmail #5

Closed
zwenza opened this issue Sep 19, 2017 · 2 comments
Closed

error in combination of isRequired and isEmail #5

zwenza opened this issue Sep 19, 2017 · 2 comments
Assignees
@dsumer
Labels
bug

Comments

@zwenza
Copy link
Contributor

zwenza commented Sep 19, 2017

Following valdiation rules will not work correct:

validations={{isRequired: false, isEmail: true}}

The validators will still want a valid email even if it's not mandatory
@zwenza zwenza added the bug label Sep 19, 2017
@dsumer
Copy link
Member

dsumer commented Sep 21, 2017

yeah that's right ... we should generally: skip all validations if the input is not required and empty

@dsumer
Copy link
Member

dsumer commented Oct 2, 2017

#6 will be fixed in version 0.1.0

@dsumer dsumer closed this as completed Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dsumer dsumer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsumer @zwenza