You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It existed because it was before C++17 and used cata::optional. However with Migrate to C++17 #1953 and cata::and_then, it does not have special utility anymore.
I'm a newbie in C++, but i think it's less preferable to extend class from STL and forward its methods.
Clang-tidy raises false positive over its every single usage.
The solution
convert all usages of optional_vpart_position into std::optional<vpart_position>.
use cata::and_then for forwarding member functions.
The text was updated successfully, but these errors were encountered:
The Situation
Cataclysm-BN/src/vpart_position.h
Lines 98 to 117 in c5e21d5
Why is it not desirable?
cata::optional
. However with Migrate to C++17 #1953 andcata::and_then
, it does not have special utility anymore.The solution
optional_vpart_position
intostd::optional<vpart_position>
.cata::and_then
for forwarding member functions.The text was updated successfully, but these errors were encountered: