Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC with bow equipped and arrows in inventory using bow for mele only. #675

Closed
Proxiehunter opened this issue Jul 17, 2021 · 7 comments
Closed
Labels

Comments

@Proxiehunter
Copy link

Told NPC to use a short bow and gave them simple wooden small game arrows. NPC is smacking zombies with the bow.

Expected behavior

NPC fires bow.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2004
  • Game Version: 458e37f [64-bit]
  • Graphics Version: Tiles
  • Game Language: []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Aftershock [aftershock],
    Arcana and Magic Items [Arcana],
    Hauling Space From Aftershock [aftershock_hauling_space],
    Alexs Mutant Power Armor [a_mutated_arsenal],
    Armor Up! PA Utilities [ArmUpPAUtil],
    Armor Up! Survivor Expansion [ArmUpSurvEx],
    Modular Turrets with No Blacklist [modular_turrets_no_blacklist],
    Bootleg Walkers [Bootleg_Walkers],
    Camping tools [camping_tools],
    CIVILIAN POWER ARMOR [CIVILIANPOWAAA],
    Flowerpot (uekibati) mod [Uekibati_mod],
    Garden Pots [growable-pots],
    Homemade Fungicide [homemade_fungicide],
    Incinerator [incinerator],
    Large capacity storage CBMs [eps_cbm],
    Makeshift engine hoist [makeshift_engine_hoist_mod],
    Makeshift Items Mod [makeshift],
    MakeshiftCanteen [MSCanteen],
    More Makeshift Stuff [makeshift_stuff],
    Power_Armor_Additions [Power_Armor_Additions],
    Sewing Machine [SM],
    Survivor's Lost item [Survivors_Lost_item],
    Hydroponics [hydroponics],
    Jury-Rigged Robots [jury_rigged_robots],
    More Survivor Stuff [more_survivor_stuff],
    Mutant NPCs [mutant_npcs],
    Wandering Masters [wandering_masters],
    Whaleys Hair Mod [WHALEYHAIR1],
    Caches [P_Caches],
    Pneumatic fun [pneumo_fun],
    Blazemod - Vehicle Additions Pack [blazemod],
    Folding Parts pack [deoxymod],
    Shrub it off [shrub_mod],
    Tankmod: Revived [Tankmod_Revived],
    Graphical Overmap [Graphical_Overmap],
    Mutation Changes Snofielf [Mutation_Changes1],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    LSM Content Pack [LSM_Content],
    Integrated Fusion Blaster [Integrated_Fusion_Blaster]
    ]

Additional context

NPC has no skill in archery. Possibly why? Still think they would give using the bow properly a try.

@nanohard
Copy link
Contributor

lol that's funny to imagine watching.
Yeah, it seems you're spot on for the reason; looks like this is the culprit for preference of attack type.
https://github.com/cataclysmbnteam/Cataclysm-BN/blob/upload/src/npcmove.cpp#L1356-L1417

@Proxiehunter
Copy link
Author

Well damn. I handed them a bow because I don't have the tools to make a crossbow and I wanted them to have a ranged option to replace the rifle I took away so they wouldn't bring the hordes down on me shooting an unsilenced rifle.

@nanohard
Copy link
Contributor

nanohard commented Jul 17, 2021

Can you look at the log (hopefully you have it in config/debug.log) and search for is trying an alternate attack, is trying to shoot someone, and is trying a melle attack ("melle" is a typo in the code, so search for it that way)
If you see it, go ahead and upload it so I can have a look.

@anothersimulacrum
Copy link
Contributor

Those types of messages will not be shown anywhere unless debug mode is enabled - and nobody has it enabled because it's super spammy.

@nanohard
Copy link
Contributor

nanohard commented Jul 17, 2021

So I just had the same issue, due to my NPC not having the proper strength (12) to use the composite bow. You should check the NPC's abilities to make sure they have the proper stats to use what you want.

I checked with guns as well; whichever does the most damage the NPC will go with.
I don't think this is a bug.

@scarf005 scarf005 added the bug label Oct 18, 2022
@KheirFerrum
Copy link
Collaborator

Should be fixed by #1705, as it contains the fix for NPCs and ranged weapons.

@scarf005
Copy link
Member

scarf005 commented May 1, 2023

please reopen the issue if #1705 does not fixes it.

@scarf005 scarf005 closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants