Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return fire issues #81

Closed
4 tasks
Coolthulhu opened this issue Sep 27, 2020 · 0 comments · Fixed by #545
Closed
4 tasks

Return fire issues #81

Coolthulhu opened this issue Sep 27, 2020 · 0 comments · Fixed by #545

Comments

@Coolthulhu
Copy link
Member

The monster defense function for return fire has a bunch of things done wrong. It copies a large block of the gun actor instead of using it.

  • Doesn't error when gun function is not found (ideally, it would be checked in MonsterGenerator::check_monster_definitions())
  • Doesn't initialize the NPC in the same way (stats, skills)
  • Won't work for weapons that require UPS
  • Is a copypaste instead of proper function reuse

Possible solutions:

  • Extract function from gun actor, use it in return fire
  • Extract shooter stat block from gun actor to monster, use it in gun actor and return fire

There's also the issue of return fire intentionally not working against throwing, which makes it easy to cheese it. The sound check could be changed to just an extra accuracy penalty if the source can't be heard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant