-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summarize archiver run and send notification via GH Action #60
Comments
In #70 this is flagged as a condition for failure, so would this not be redundant? Or do you mean if we change the script to include different partitions between archive runs this should be explicitly noted by our archiver? Otherwise I think this covers all our bases. This seems a bit lengthy for a slack message so presumably one of the other communication options will make more sense here. |
I'm thinking that the archiver summary report (Maybe it's a JSON object?) will be the thing that's evaluated to decide whether the run failed. Some changes in the set of data partitions are fine and expected -- e.g. a new month of eia860m data -- but we'd still want to see that change reflected in the summary. Most kinds of changes would be unexpected and bad though -- say the 1995 California EPA CEMS data disappears, or the name of the PHMSA underground natural gas storage partition changes from I think automatically posting the summary of the run as an issue, assigning someone to review it, and then posting links to the issue on Slack / Twitter / Wherever makes sense. It'll be persistent and public and someone will be explicitly tasked with reviewing it, and it'll show up in a place where we can have some discussion and easily spin off new issues if there's something that needs to be fixed. |
Scope:
Next steps
|
I think we need to summarize and communicate the status of the run regardless of whether a new version is published. If the run fails, we need to know that and whatever useful error information was collected. Under some circumstances even "no change" is suspicious. E.g. if the monthly EPA CEMS hasn't updated in 60 days, it should get flagged for review. |
That makes sense to me. If I'm understanding correctly your proposal, @zaneselvans, we publish an issue weekly with the information listed above. Most weeks this should look good and we just close it immediately. I think if that's our plan then ideally we'd name the issue to reflect the status of the run, or at least reflect the success status in the slack message. If key failures are occurring it'd be useful to know to prioritize fixing them. |
With the move to automated archiving, there's a need to easily and visibly summarize the outcome of the automated archival run. Communication should summarize the status of each archiver's run, and any critical warnings or errors. We could also use this as a chance to create a public record of what's new in each deposition.
Who/Where to notify?
The hope is that these archives will be a public resource, so producing a persistent public record of the data updates and/or allowing the general public to get access to this information would be good. Some options:
Notification / Summary contents?
The text was updated successfully, but these errors were encountered: