Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove dev branch #3179

Closed
16 tasks done
Tracked by #3140
jdangerx opened this issue Dec 20, 2023 · 3 comments · Fixed by #3212 or #3216
Closed
16 tasks done
Tracked by #3140

Deprecate and remove dev branch #3179

jdangerx opened this issue Dec 20, 2023 · 3 comments · Fixed by #3212 or #3216
Assignees
Labels
cloud Stuff that has to do with adapting PUDL to work in cloud computing context. docs Documentation for users and contributors. nightly-builds Anything having to do with nightly builds or continuous deployment. release Tasks directly related to data and software releases.

Comments

@jdangerx
Copy link
Member

jdangerx commented Dec 20, 2023

Tasks

@jdangerx jdangerx changed the title Remove dev branch Deprecate dev branch Dec 20, 2023
@jdangerx jdangerx changed the title Deprecate dev branch Deprecate and remove dev branch Dec 20, 2023
@zaneselvans zaneselvans added docs Documentation for users and contributors. cloud Stuff that has to do with adapting PUDL to work in cloud computing context. release Tasks directly related to data and software releases. nightly-builds Anything having to do with nightly builds or continuous deployment. labels Jan 4, 2024
@zaneselvans zaneselvans self-assigned this Jan 4, 2024
@zaneselvans zaneselvans linked a pull request Jan 4, 2024 that will close this issue
@zaneselvans
Copy link
Member

What do we think the appropriate branch protections are for main, nightly, and stable?

It seems like nightly and stable should only every be modified by the automated processes (unless something goes awry).

The protections we have on dev right now seem like they would probably get moved to main? Namely that it has to be changed by a PR with at least one reviewer, and all the "required" CI checks need to pass?

@zaneselvans
Copy link
Member

zaneselvans commented Jan 5, 2024

Verifying that our first successful main/nightly/stable build behaved as expected:

  • nightly-YYYY-MM-DD tag was created
  • nightly branch was updated to point at main
  • build outputs were written to gs://builds.catalyst.coop/BUILD_ID
  • appropriate build outputs were copied to gs://pudl.catalyst.coop/nightly
  • appropriate build outputs were copied to s3://pudl.catalyst.coop/nightly
  • Datasette was redeployed with build outputs
  • PAT is not present in published logfile

@zaneselvans
Copy link
Member

Issues:

  • We're not capturing logging output from all of the commands inside the composite functions, like when the files are copied to S3, but the files are being copied and if the copy failed, I think we'd get a build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud Stuff that has to do with adapting PUDL to work in cloud computing context. docs Documentation for users and contributors. nightly-builds Anything having to do with nightly builds or continuous deployment. release Tasks directly related to data and software releases.
Projects
Archived in project
2 participants