Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Generalized Mean Pooling #1084

Closed
Atharva-Phatak opened this issue Feb 27, 2021 · 4 comments
Closed

[Feature] Generalized Mean Pooling #1084

Atharva-Phatak opened this issue Feb 27, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Atharva-Phatak
Copy link
Contributor

Atharva-Phatak commented Feb 27, 2021

🚀 Feature Request

I would catalyst to have an implementation of GeM(Generalized Mean Pooling) as proposed in this paper

Motivation

Well I like to use catalyst's contrib features very much and it has an amazing set of pooling methods available(GlobalMaxPool2d ,
GlobalConcatPool2d ,etc). I think that an implementation of GeM pooling will be a nice addition to the pooling module of catalyst.

Note

Goes without saying that I will work on this implementation myself

@Atharva-Phatak Atharva-Phatak added enhancement New feature or request help wanted Extra attention is needed labels Feb 27, 2021
@github-actions
Copy link

Hi! Thank you for your contribution! Please re-check all issue template checklists - unfilled issues would be closed automatically. And do not forget to join our slack for collaboration.

@Scitator
Copy link
Member

Hi,

The idea with the contrib pooling looks great for me (especially for our representation learning track). In this case, if you have time and motivation – it would be a valuable contribution. As far as there is already an implementation from the authors, I hope it would be a bit easier to add to the contrib. Nevertheless, ensure please that you have added docs and a few tests for new functionality. I know, that is not the most interesting part of the contribution, but the most long-term one for the user adoption.

@Atharva-Phatak
Copy link
Contributor Author

Definetly, I will create a pull request including documentation and the required tests along with accepted implementations

Also since you mentioned representation learning for catalyst, would like to add more modules/Loss functions ? Like arcface , cosface, etc?

@Scitator
Copy link
Member

The interesting thing... we already have many arcfaces implemented and tested. The same for metric learning.

That's why all modules/losses/approaches for representation and metric learning are always welcome in the Catalyst ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants