Dev22 - DDP engines update #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
catalyst/callbacks/checkpoint.py
Outdated
| try: | ||
| unwrapped_model = runner.engine.unwrap_model(runner.model) | ||
| unwrapped_model.load_state_dict(load_checkpoint(resume_logpath)) | ||
| except: |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
B901 blind except: statement
catalyst/callbacks/checkpoint.py
Outdated
| try: | ||
| unwrapped_model = runner.engine.unwrap_model(runner.model) | ||
| unwrapped_model.load_state_dict(load_checkpoint(resume_logpath)) | ||
| except: |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
E722 do not use bare 'except'
catalyst/callbacks/checkpoint.py
Outdated
| try: | ||
| unwrapped_model = runner.engine.unwrap_model(runner.model) | ||
| unwrapped_model.load_state_dict(load_checkpoint(resume_logpath)) | ||
| except: |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
B001 Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -138,6 +145,9 @@ def spawn(fn: Callable, *args, **kwargs): | |||
| world_size: int = 8 | |||
| return xmp.spawn(fn, args=(world_size,), nprocs=world_size, start_method="fork") | |||
|
|
|||
| def setup(self, local_rank: int, world_size: int): | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
D102 Missing docstring in public method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request FAQ
Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Checklist
latestrequirements? Please attach the notebook link.minimalrequirements? Please attach the notebook link.