New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllowCreate flag explicitly set to true #779

Open

jwalits opened this issue Oct 16, 2023 · 0 comments

Contributor

jwalits commented Oct 16, 2023

It looked like previously the AllowCreate flag (https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/settings.php#L201-L206) wasn't really supported in the SAML request.

With the latest change, it looks like we are explicitly setting it to true in the SAML config: https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/config/authsources.php#L66

Need to find a middle ground for that value. Having it hardcoded to true in the config doesn't feel right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment