Translations are not available in AMOS

[germanvaleroelizondo]

Hi,
This plugin can not be translated in AMOS.
String concatenation is not allowed.
Please check the plugins checklist for strings at https://docs.moodle.org/dev/index.php?title=Plugin_contribution_checklist&redirect=no#Strings .

Thanks in advance.

[danmarsden]

Whoops! - missed that in my review! Thanks for the report - we'll get that fixed next week!

[DrCuriosity]

My apologies for not catching more opportunities to internationalise the strings earlier. I removed some string hard-coding from the original plugin, but I appear to have added some of my own. I will be more careful about that in future.

From an initial look-through I have found these two things to fix, and I will work on them in the morning:

• https://github.com/catalyst/moodle-local_cohortauto/blob/master/view.php#L86
• cli_writeln() functions in https://github.com/catalyst/moodle-local_cohortauto/tree/master/cli

I will also conduct a more careful check once that is done.

If you can see any other places where correction is obviously needed, do please let me know and I will address them as promptly as I can. Thank you!

[danmarsden]

@DrCuriosity - Amos doesn't cope with string concatenation- eg 'line1'.'line2'

[danmarsden]

Eg:

moodle-local_cohortauto/lang/en/local_cohortauto.php

Line 43 in a4b0f46

. '<p><b>NOTE:</b> <i>You <b>cannot</b> edit converted cohorts manually!</i></p>'

[DrCuriosity]

Understood. Will make that conversion, and do it as a PR for review.

[DrCuriosity]

Code updated, and version reuploaded to moodle.org. Is there anything further that needs to be done in order for AMOS to pick up the change?

[danmarsden]

nope that should be it - thanks David! - @germanvaleroelizondo - let us know if you have any further issues!

[germanvaleroelizondo]

Hi,
Strings are now available in AMOS for translation.
Thanks.