Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File links are not decoded on restore #123

Open
dmitriim opened this issue May 7, 2024 · 1 comment
Open

File links are not decoded on restore #123

dmitriim opened this issue May 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dmitriim
Copy link
Member

dmitriim commented May 7, 2024

Seems like define_decode_contents doesn't decode everything correctly.

If you add something like this to your content

<p><img class="img-fluid align-top" role="presentation" src="https://moodle.localhost/pluginfile.php/22/mod_page/content/2/vid-introduction-pic.png" alt="" width="1300" height="550"></p>

On restore you will get something like this:

<img class="img-fluid align-top" role="presentation" src="$@PLUGINFILEBYCONTEXT*22@$/mod_page/content/2/vid-introduction-pic.png" alt="" width="1300" height="550">

@dmitriim dmitriim added the bug Something isn't working label May 7, 2024
@dmitriim
Copy link
Member Author

dmitriim commented May 7, 2024

Seems like it's a core issue. I can replicate it on master for course custom fields. However, potentially this plugin would need to implement decoding when core supports it,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant