Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechecker issues found since #31 #32

Closed
keevan opened this issue Nov 10, 2021 · 0 comments · Fixed by #33
Closed

Codechecker issues found since #31 #32

keevan opened this issue Nov 10, 2021 · 0 comments · Fixed by #33

Comments

@keevan
Copy link
Contributor

keevan commented Nov 10, 2021

For example: https://github.com/catalyst/moodle-tool_forcedcache/runs/4161249845?check_suite_focus=true


Run moodle-plugin-ci codechecker
 RUN  Moodle Code Checker on tool_forcedcache
........E..W... 15 / 15 (100%)

FILE: /home/runner/work/moodle-tool_forcedcache/moodle-tool_forcedcache/moodle/admin/tool/forcedcache/classes/check/enabled.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 26 | ERROR | Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
    |       | (moodle.Files.MoodleInternal.MoodleInternalGlobalState)
------------------------------------------------------------------------------------------------------------------------------------


FILE: ...ner/work/moodle-tool_forcedcache/moodle-tool_forcedcache/moodle/admin/tool/forcedcache/classes/cache_administration_helper.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 261 | WARNING | Inline comments must end in full-stops, exclamation marks, or question marks
     |         | (moodle.Commenting.InlineComment.InvalidEndChar)
------------------------------------------------------------------------------------------------------------------------------------

Time: 1.37 secs; Memory: 18MB

Error: Process completed with exit code 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant