Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with rangerequestcheck #111

Closed
brendanheywood opened this issue Apr 29, 2022 · 2 comments
Closed

Bug with rangerequestcheck #111

brendanheywood opened this issue Apr 29, 2022 · 2 comments

Comments

@brendanheywood
Copy link
Contributor

Exception - Cannot access protected property tool_heartbeat\check\rangerequestcheck::$component

@matthewhilton
Copy link
Contributor

Encountered this issue in Totara 12.
Changed lib/classes/check/manager.php line 82 from
$check->component = $plugintype . '_' . $plugin;
to
$check->set_component($plugintype . '_' . $plugin);
Full stack trace:

Exception - Cannot access protected property tool_heartbeat\check\rangerequestcheck::$component

Debug info:
Error code: generalexceptionmessage
Stack trace:
line 82 of /lib/classes/check/manager.php: Error thrown
line 56 of /lib/classes/check/manager.php: call to core\check\manager::get_performance_checks()
line 72 of /lib/classes/check/table.php: call to core\check\manager::get_checks()
line 35 of /report/performance/index.php: call to core\check\table->__construct()

The check API is moodle is using the correct set_component method - so this bug is unlikely due to check api or heartbeat and just with a specific backport of the check api to totara.

@TomoTsuyuki
Copy link

The issue has been fixed in
https://tracker.moodle.org/browse/MDL-72924
which is deployed to Moodle 3.10+.
For older version of Moodle or Totara, need to backport to solve the issue.
moodle/moodle@086878c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants