Test data of repeat view is missing

[ZackZhou]

[Docker Image]It seems that the data of repeat view is missing on report page, since tag version "release - DIGSET a66664d46ab9". The last working tag is "21.07".

[jcedborger]

I also have this issue. Specifying fvonly to false(0), but successfulRvRuns is 0.

Running the agent on a private ec2 instance, installed with the directions from the official docs.

        "url": "https://***.***",
        "summary": "***/results.php?test=211105_2C_7",
        "testUrl": "https://***.***",
        "location": "eu-north-1:Chrome",
        "from": "Europe (Stockholm) - <b>Chrome</b> - <b>custom</b>",
        "connectivity": "custom",
        "bwDown": 20000,
        "bwUp": 2000,
        "latency": 30,
        "plr": "0",
        "shaperLimit": 0,
        "mobile": 0,
        "label": "1L7XoBeTKnuYKscgtos-ZWi2ZbMq3ZUU3kKyBg-f7FvA___Custom Mobile 4G___1___2021-11-06 003248",
        "completed": 1636155263,
        "testRuns": 3,
        "fvonly": false,
        "successfulFVRuns": 3,
        "successfulRVRuns": 0,```

[nstahle]

I can confirm this issue. Spent so many hours trying to debug this in my setup. I have a private instance setup to pull from release branch, changed this to "21.07" and repeat views started working again. I tried using "21.07.1" and I can't get repeat view to work there. So I suspect that something broke at "21.07.1" and has been broken since.

[alexandrul]

There is an issue with the fvonly parameter sent by the server.

21.07 (the most recent tag available on docker hub) is sending fvonly=1 if we select First View Only and is omitting it if we select First View and Repeat View.
This commit (just a few days later) is ensuring that fvonly is sent in both cases: catchpoint/WebPageTest@d29462f

At the same time, the agent forces fvonly=1 if fvonly is not found in the received payload, making it impossible to use the repeat view when using the above server version: https://github.com/WPO-Foundation/wptagent/blob/master/internal/webpagetest.py#L516-L517

                if 'fvonly' not in job:
                    job['fvonly'] = 1

Since the team is working on the server's docker script, I have no clue when a new server tag will be available on docker hub: catchpoint/WebPageTest#1706

A possible solution would be to reuse the testrv option as seen here: https://github.com/WPO-Foundation/wptagent/blob/master/wptagent.py#L150-L151

                            if 'fvonly' not in test_json:
                                test_json['fvonly'] = not self.options.testrv

I'm not sure if this is the best approach, but it's working fine on my PC.