Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'getName function' is deprecated and will be removed #34

Closed
catdad opened this issue Oct 27, 2019 · 2 comments · Fixed by #47
Closed

'getName function' is deprecated and will be removed #34

catdad opened this issue Oct 27, 2019 · 2 comments · Fixed by #47
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@catdad
Copy link
Owner

catdad commented Oct 27, 2019 •
edited

I don't know what this error is or how to reproduce it... investigate later.

image

It happened on c647f20, for line number info.
@catdad catdad added help wanted Extra attention is needed bug Something isn't working labels Oct 27, 2019
@erickzhao
Copy link
Contributor

The bug seems related to the app you're running. The app.getName() API and its counterpart app.setName() were deprecated some time ago.

The fix would just be to replace any instances of app.getName() with app.name.

@erickzhao erickzhao mentioned this issue Mar 3, 2020
Merged
@catdad catdad closed this as completed in #47 Mar 3, 2020
@catdad
Copy link
Owner Author

catdad commented Mar 4, 2020

Published in 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update app.getName() -> app.name erickzhao/electronmon
2 participants
@catdad @erickzhao