Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run grandma diff report with a single glob #124

Open
catdad opened this issue Mar 31, 2017 · 2 comments
Open

run grandma diff report with a single glob #124

catdad opened this issue Mar 31, 2017 · 2 comments

Comments

@catdad
Copy link
Owner

catdad commented Mar 31, 2017

Right now, --logs takes one glob each for all the separate logs, treating each glob as a single report. This is useful, but not all too convenient.

Most tests I run only have one file per test, and so I would like to also have an option to provide a single glob and treat each file in the glob as a separate log to diff.

@catdad
Copy link
Owner Author

catdad commented Apr 3, 2017

Actually, I implemented globing wrong apparently, so this is already how --logs works.

grandma diff -l out/pccis* out/dcs* out/sss*

Results in all files being treated separately in the diff (i.e. there are like 12 separate reports in the diff, rather than 3).

So really I need to implement the version that combines all files in each glob, similarly to how the text and json reporters work.

@catdad
Copy link
Owner Author

catdad commented Apr 4, 2017

Never mind, the above comment it not really true.

In bash, globs are automatically expanded by bash itself before being passed into the command, and therefore, the above example worked in Linux. However, it does not work on Windows. See #127 for more info.

In short, this is something bash does and it is not really supported as a proper grandma feature. For those using bash, that's great... they can get both behaviors on a single command... provided they don't get confused. For others, like Windows users, this feature still needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant