Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration support (good first issue) #7

Closed
Antonboom opened this issue Oct 19, 2023 · 4 comments
Closed

Configuration support (good first issue) #7

Antonboom opened this issue Oct 19, 2023 · 4 comments

Comments

@Antonboom
Copy link
Contributor

Just so we don't forget the idea :)

What (DRAFT):

perfsprint:
  enabled:
    - string    # Just using string
    - error     # Just using Error()
    - bool      # strconv.FormatBool
    - hex       # hex.EncodeToString
    - int       # strconv.Itoa or strconv.FormatInt
    - uint      # strconv.FormatUint
  int:
      # Enable int and int64 only mode
      no-type-conversions: true
  uint:
      # Enable uint64 only mode
      no-type-conversions: true

How to:
#1 (comment)

@Antonboom Antonboom changed the title Configuration support Configuration support (good first issue) Oct 19, 2023
@catenacyber
Copy link
Owner

What do you think of e958370 ?

@Antonboom
Copy link
Contributor Author

Antonboom commented Oct 24, 2023

@catenacyber, very pretty and accurate solution

Proposals

optimizes even if it needs an int conversion

->

optimizes even if it requires an int or uint type cast

Reflect new flag in README#Usage

@catenacyber
Copy link
Owner

Done

Is this good for you ?
Should I do a 0.3 tag release and make a PR to golangci-lint to use this ?

@Antonboom
Copy link
Contributor Author

Antonboom commented Oct 24, 2023

Should I do a 0.3 tag release and make a PR to golangci-lint to use this ?

yes, but better v0.2.1

Is this good for you ?

feel free to close any of my issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants