Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Copy the card ID #10

Closed
TheLastProject opened this issue Oct 24, 2020 · 6 comments
Closed

New feature: Copy the card ID #10

TheLastProject opened this issue Oct 24, 2020 · 6 comments

Comments

@TheLastProject
Copy link
Member

Issue by denilsonsa
Friday Feb 10, 2017 at 20:28 GMT
Originally opened as brarcher/loyalty-card-locker#90


  1. I select the saved card from the initial screen.
  2. Now I can see all the details. But I can't copy.
    • I wish I could tap on the card ID and it would copy it.
    • To improve the user feedback, upon copying it should display a message (toaster) saying the id was copied.
    • To increase the discoverability of this feature, a copy icon can be added next to the card id.

This feature is specially useful for airline mileage numbers, or any number that can be used during online purchases.

It might be worth also implementing this "copy" feature to the "Note" field.

@TheLastProject
Copy link
Member Author

Comment by brarcher
Friday Feb 10, 2017 at 20:39 GMT


Do you mean copying the card id to the clipboard?

@TheLastProject
Copy link
Member Author

Comment by denilsonsa
Friday Feb 10, 2017 at 20:54 GMT


Yes, exactly that.

@TheLastProject
Copy link
Member Author

Comment by brarcher
Sunday Feb 12, 2017 at 03:52 GMT


The previous layout was not that great, in that it was showing data using a disabled EditView.

Pull Request brarcher/loyalty-card-locker#91 updates the screen, so that the data is shown using a TextView. Further, if one long clicks a field it can be selected and copied to the clipboard.

The change will be available in the next release. Let me know if this satisfies your request.

@TheLastProject
Copy link
Member Author

Comment by brarcher
Monday Feb 13, 2017 at 03:01 GMT


It did not occur to me when you asked, but there is already a feature very similar to your request. If you long press the card entry from the main page a menu will appear. That menu allows one to copy the card ID to the clipboard.

I see that this feature may not be obvious. If you have any suggestions on how to improve its discoverability, please let me know.

@TheLastProject
Copy link
Member Author

Comment by denilsonsa
Sunday Feb 26, 2017 at 09:34 GMT


I didn't know about that long-tap menu. That's cool. 👍

I tested the new version, I can now long-tap to select and copy text. That's great! 👍 But I cannot do that in the "edit" screen. 😞 (I am suggesting an idea on #89)

The only improvement I can think about is also adding a "copy" button that copies the entire card ID (or the entire note) in one tap. Still, don't remove the ability to select text, I like being able to select a portion of the note to copy, it is helpful in some occasions.

@TheLastProject
Copy link
Member Author

The new edit UI made this selectable in the edit screen. So closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant