Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space card numbers #1679

Closed
pikrzysztof opened this issue Jan 1, 2024 · 2 comments
Closed

Space card numbers #1679

pikrzysztof opened this issue Jan 1, 2024 · 2 comments

Comments

@pikrzysztof
Copy link

I'd like the app to not display long card numbers in one continuous sequence and group digits in threes or fours instead.

Example:

This is the current way of presenting card digits

image

what I'd like to see instead:

spaces

@TheLastProject
Copy link
Member

I don't think Catima should make assumptions on the correct way to display card values especially because it may affect the receiving end (if I get a coupon with code "12345678" and I enter it as "1234 5678" on the store's website, the coupon may be refused).

As I see it, manually changing the Card ID value to make it contain a space is a decent enough workaround for those who want the code to be displayed in a prettier way regardless of validity.

@TheLastProject TheLastProject closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2024
@pikrzysztof
Copy link
Author

I don't think Catima should make assumptions on the correct way to display card values especially because it may affect the receiving end (if I get a coupon with code "12345678" and I enter it as "1234 5678" on the store's website, the coupon may be refused).

That's a fair point. But we still can do better for readability. We can use colours:

image

or underlining:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants