Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ulauncher #112

Closed
lighttigerXIV opened this issue Mar 27, 2022 · 22 comments
Closed

Ulauncher #112

lighttigerXIV opened this issue Mar 27, 2022 · 22 comments
Labels
port request Port Catppuccin to this app

Comments

@lighttigerXIV
Copy link
Contributor

Are you available to help in the creation of this port? 😄 (optional)
Yes

This time i made a theme for ulauncher, another keyboard launcher and i would like you to see if it's good enough for this community :P
And add it here of course.

The repo i made: https://github.com/lighttigerXIV/Catppuccin-Ulauncher

@lighttigerXIV lighttigerXIV added the port request Port Catppuccin to this app label Mar 27, 2022
@nekowinston nekowinston added the draft available A basis for a port has been created label Aug 14, 2022
@Xurdejl
Copy link
Member

Xurdejl commented Sep 25, 2022

@lighttigerXIV
I've opened a pull request with some changes and the remaining flavours.

Also, in order to ensure consistency, you should rename the repository to "ulauncher" in lowercase, change the description to something like "🇺 Soothing pastel theme for Ulauncher" and add "catppuccin" to the topics.

@lighttigerXIV
Copy link
Contributor Author

@lighttigerXIV I've opened a pull request with some changes and the remaining flavours.

Also, in order to ensure consistency, you should rename the repository to "ulauncher" in lowercase, change the description to something like "🇺 Soothing pastel theme for Ulauncher" and add "catppuccin" to the topics.

It should be okay now.

@lighttigerXIV
Copy link
Contributor Author

lighttigerXIV commented Sep 26, 2022

@Xurdejl I merged your request and changed the read me copy command. Nice job for the other ports 😁.

@Xurdejl
Copy link
Member

Xurdejl commented Sep 26, 2022

Nice! This should be now ready for review.

@lighttigerXIV
Copy link
Contributor Author

I noticed that frappe round wasn't with the correct colors so i changed it

@Xurdejl
Copy link
Member

Xurdejl commented Oct 7, 2022

Hey @nekowinston, could you label this as ready for review, please? ^^

@nekowinston nekowinston added ready for review and removed draft available A basis for a port has been created labels Oct 7, 2022
@nekowinston
Copy link
Member

Thanks for the ping @Xurdejl! Labeled it.

The repo looks good, but I noticed that the emoji in the description doesn't render at all on my Linux machine, and looks broken on my macOS. 🤔

Those links are currently mixed and will have to be fixed as well:
https://github.com/lighttigerXIV/ulauncher/blob/79f7e21e5918058860040f30283a5447a81396f1/README.md?plain=1#L8-L12

I'll invite @lighttigerXIV to the org, feel free to transfer it once the README is adapted 🙂

@nekowinston
Copy link
Member

Oh and I just saw that Ulauncher is on GitHub as well, we usually prefer links to the GitHub repos (for the app name header) instead when available: https://github.com/Ulauncher/Ulauncher/

@lighttigerXIV
Copy link
Contributor Author

Thanks for the ping @Xurdejl! Labeled it.

The repo looks good, but I noticed that the emoji in the description doesn't render at all on my Linux machine, and looks broken on my macOS. thinking

Those links are currently mixed and will have to be fixed as well: https://github.com/lighttigerXIV/ulauncher/blob/79f7e21e5918058860040f30283a5447a81396f1/README.md?plain=1#L8-L12

I'll invite @lighttigerXIV to the org, feel free to transfer it once the README is adapted slightly_smiling_face

Do you have noto font emoji installed? On my machine it shows up fine

@lighttigerXIV lighttigerXIV reopened this Oct 7, 2022
@nekowinston
Copy link
Member

Yes, noto-fonts-emoji makes it work, but it's still broken on macOS for me - seems that regional indicator emojis don't show on GitHub when on macOS.

Anyways, don't let the description emoji hinder you, just the README fixes are good enough 👍

@lighttigerXIV
Copy link
Contributor Author

Yes, noto-fonts-emoji makes it work, but it's still broken on macOS for me - seems that regional indicator emojis don't show on GitHub when on macOS.

Anyways, don't let the description emoji hinder you, just the README fixes are good enough 👍

I think i fixed them. You can check them now

@nekowinston
Copy link
Member

After merging that PR, you can transfer the repository @lighttigerXIV

@nekowinston
Copy link
Member

@lighttigerXIV sorry for another ping, but could you please accept the invite and transfer the repository to catppuccin/ulauncher? 🙂

@lighttigerXIV
Copy link
Contributor Author

@lighttigerXIV sorry for another ping, but could you please accept the invite and transfer the repository to catppuccin/ulauncher? 🙂

Where do i need to go? I can't find anything about that transfer. Not even a notification

1 similar comment
@lighttigerXIV
Copy link
Contributor Author

@lighttigerXIV sorry for another ping, but could you please accept the invite and transfer the repository to catppuccin/ulauncher? 🙂

Where do i need to go? I can't find anything about that transfer. Not even a notification

@nekowinston
Copy link
Member

You should've got an invitation email, at least an open invitation here: https://github.com/settings/organizations

@lighttigerXIV
Copy link
Contributor Author

You should've got an invitation email, at least an open invitation here: https://github.com/settings/organizations

Do i need to create a repository and fork now?

@nekowinston
Copy link
Member

Neither. Please go to https://github.com/lighttigerXIV/ulauncher/settings, scroll all the way down, and use "Transfer Ownership" -> to "catppuccin"

@lighttigerXIV
Copy link
Contributor Author

lighttigerXIV commented Oct 10, 2022

Neither. Please go to https://github.com/lighttigerXIV/ulauncher/settings, scroll all the way down, and use "Transfer Ownership" -> to "catppuccin"

Just delete the one i created before XD. I can't transfer now because it says it already exists XD

@lighttigerXIV
Copy link
Contributor Author

Sorry for this mess XD

@nekowinston
Copy link
Member

Alright, it's deleted.

Sorry for this mess XD

No worries.

@lighttigerXIV
Copy link
Contributor Author

Alright, it's deleted.

Sorry for this mess XD

No worries.

Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port request Port Catppuccin to this app
Projects
None yet
Development

No branches or pull requests

3 participants