Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

xed #1791

Closed
justTOBBI opened this issue Dec 30, 2022 · 5 comments 路 Fixed by #1866
Closed

xed #1791

justTOBBI opened this issue Dec 30, 2022 · 5 comments 路 Fixed by #1866
Labels
port request Port Catppuccin to this app waiting on author Waiting on action from the maintainer

Comments

@justTOBBI
Copy link
Member

Are you available to help in the creation of this port? 馃槃 (optional)
Yes

Additional context 馃摲 (optional)
Already made a repo here: https://github.com/justTOBBI/xed

@justTOBBI justTOBBI added the port request Port Catppuccin to this app label Dec 30, 2022
@nullishamy
Copy link
Contributor

This looks great!

@sgoudham
Copy link
Contributor

sgoudham commented Jan 14, 2023

Hiya 馃憢 I'm about to check it properly now but I just have a few comments from just skimming the files:

  1. Could you please change the default branch from master -> main?
  2. Our cursor highlights across all themes should be rosewater
  3. "def:preprocessor" should be sky instead of mauve
  4. "def:constant" should be peach instead of green
  5. "def:shebang" should be subtext0 instead of base (this actually makes shebangs invisible!!!)
  6. "def:operator" should be teal instead of green
  7. In the description of all files, Pastell is misspelled
  8. The screenshot on the main README also has some font rendering issues, for example, look at the title:

weird text artefacts (this also appears in the rest of the screenshot)
image

I'll add more comments if I find anything else, just going to install it now

@sgoudham sgoudham added the waiting on author Waiting on action from the maintainer label Jan 14, 2023
@justTOBBI
Copy link
Member Author

image
this is what it currenty ks ike

@sgoudham
Copy link
Contributor

sgoudham commented Jan 16, 2023

Sorry, I didn't think xed highlighted those strings as constants, those tags should be green!

@justTOBBI
Copy link
Member Author

Hey, so I just fixed the few colors and the spelling mistakes, for the screenshot, I can't figure out, why this happens, so maybe someone else could make 4 screenshots for me?

@sgoudham sgoudham linked a pull request Jan 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port request Port Catppuccin to this app waiting on author Waiting on action from the maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants