Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Music CSS #197

Closed
nonetrix opened this issue Jul 17, 2022 · 14 comments · Fixed by #1725
Closed

YouTube Music CSS #197

nonetrix opened this issue Jul 17, 2022 · 14 comments · Fixed by #1725
Labels
port request Port Catppuccin to this app userstyle A website that is themed via Stylus. Userstyles must be Pull Requested into catppuccin/userstyles

Comments

@nonetrix
Copy link
Contributor

Are you available to help in the creation of this port? 😄 (optional)
Maybe I am good at CSS I am not good at picking the right colors probably

Additional context 📷 (optional)
https://music.youtube.com
Screenshot from 2022-07-16 23-56-21

Screenshot from 2022-07-16 23-56-36

@nonetrix nonetrix added the port request Port Catppuccin to this app label Jul 17, 2022
@WitherCubes
Copy link
Member

You can check out the style guide and other ports like Whoogle, MonkeyType, Youtube, etc.

@nekowinston
Copy link
Member

I'd suggest closing this issue here and maybe tracking it on https://github.com/catppuccin/youtube/issues

It's the same domain, we could have an additional UserCSS for the music subdomain — what's your take on this @andreasgrafen?

@unseen-ninja
Copy link
Member

Hmm. I'm not sure how different everything is in comparison to just regular youtube in terms of markup etc. So I'd opt for a separate Stylesheet that exclusively works with Youtube Music. I agree that this could be tracked in the Youtube Repo directly tho. c:

@isabelincorp isabelincorp added the userstyle A website that is themed via Stylus. Userstyles must be Pull Requested into catppuccin/userstyles label Oct 18, 2022
@rubyowo
Copy link
Member

rubyowo commented Oct 23, 2022

I did this https://github.com/rubyowo/youtubemusic

@nekowinston
Copy link
Member

@andreasgrafen

I'd opt for a separate Stylesheet that exclusively works with Youtube Music.

Would you be open to add your stylesheet as an extension to catppuccin/youtube @rubyowo?

Sadly, I don't have time to help out with this today.

@rubyowo
Copy link
Member

rubyowo commented Oct 23, 2022

sure

@AnubisNekhet
Copy link
Member

@andreasgrafen

I'd opt for a separate Stylesheet that exclusively works with Youtube Music.

Would you be open to add your stylesheet as an extension to catppuccin/youtube @rubyowo?

Sadly, I don't have time to help out with this today.

The way the theming system works rn, the youtube music userstyle would need to be rewritten to match the youtube format.

@nekowinston
Copy link
Member

I don't mind if you make this a separate file as well – that's up to you.

@rubyowo
Copy link
Member

rubyowo commented Oct 24, 2022

right. though how would we add it into the youtube repo?
would it be a separate folder in src/?

@nekowinston
Copy link
Member

I'd like @elkrien's opinion on this, since they're the maintainer for that repository.

@elkrien
Copy link
Contributor

elkrien commented Oct 24, 2022

It's up to You @rubyowo. If You want to add it to YouTube repo I suggest putting it to src and assets and update Readme. If You wish I will add You to YouTube owners (if I can) and You will be able to make changes.
But don't know If it won't be easier to have it in separate repo like it is right now. Will be easier for You just to transfer repo to Catppuccin organization instead doing so many changes. Also from user's perspective I think it will be easier to find and read install instructions if this will be separate repos.

@rubyowo
Copy link
Member

rubyowo commented Nov 6, 2022

It is I again, this time knowing what I would like. It'll be easier to maintain if in a separate repo, and now that it isn't just one single file anymore, it makes more sense, so I'd like to transfer it in rather than just adding it to the youtube repo

@nekowinston
Copy link
Member

@rubyowo if you want a separate repository so you can add more functionality & track issues easier, that's fine with me.

You should have permissions to transfer already 🙂

Repo looks good.

@rubyowo
Copy link
Member

rubyowo commented Nov 6, 2022

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port request Port Catppuccin to this app userstyle A website that is themed via Stylus. Userstyles must be Pull Requested into catppuccin/userstyles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants