Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity #216

Closed
AnubisNekhet opened this issue Aug 14, 2022 · 14 comments
Closed

Infinity #216

AnubisNekhet opened this issue Aug 14, 2022 · 14 comments
Labels
port request Port Catppuccin to this app

Comments

@AnubisNekhet
Copy link
Member

Are you available to help in the creation of this port? 馃槃 (optional)
No

Additional context 馃摲 (optional)
Infinity is an alternative reddit client for android with support of creating themes and importing/exporting them as JSON files.

@AnubisNekhet AnubisNekhet added the port request Port Catppuccin to this app label Aug 14, 2022
@nekowinston
Copy link
Member

Seems like there is a 0.1.0 port, which might help with the 0.2.0 version:
https://github.com/lepz0r/Infinity-For-Reddit

@nekowinston nekowinston added the draft available A basis for a port has been created label Aug 14, 2022
@skinatro
Copy link

skinatro commented Sep 9, 2022

does anybody knows any method how to convert the java negative integer values back to hex?

@nekowinston
Copy link
Member

nekowinston commented Sep 9, 2022

@skinatro if you have:

{
   "bottomAppBarBackgroundColor": -14803410
}

In JS, you could do:

console.log("#" + (0xFFFFFF & -14803410).toString(16))
// #1e1e2e

A total conversion function in TS/JS:

#!/usr/bin/env deno run
const androidToHex = (androidColor) => {
  return "#" + (0xFFFFFF & androidColor).toString(16)
}

const hexToAndroid = (hexColor) => {
  const x = parseInt(hexColor.replace("#", ""), 16) - 0x1000000
  return x
}

let a = androidToHex(-14803410)
let h = hexToAndroid("#1e1e2e")
console.log(a, h)
// -> #1e1e2e -14803410

@Xurdejl
Copy link
Member

Xurdejl commented Sep 9, 2022

I have a port for this app.
https://github.com/Xurdejl/infinity-for-reddit.

@nekowinston
Copy link
Member

@Xurdejl that is simply lovely! Thanks for your port, let me invite you to the org.

Glad to see catwalk being used again. 馃檪

@nekowinston nekowinston added ready for review and removed draft available A basis for a port has been created labels Sep 9, 2022
@unseen-ninja
Copy link
Member

unseen-ninja commented Sep 9, 2022

I've been test-driving each theme for a couple minutes now. I can't spot anything out of the ordinary. I def. approve this one. It's great! c:
Likely to make me switch back to Infinity again actually. xd

Screenshots

01_infinity_latte
02_infinity_frappe
03_infinity_macchiato
04_infinity_mocha

Edit: nvm.. I don't know why this is highlighted like this, but it's kinda unreadable.. o:

IMG_20220910_003520.jpg

@skinatro
Copy link

thanks a lot, will be useful for other android themes as well

@Xurdejl
Copy link
Member

Xurdejl commented Sep 10, 2022

Oh, I missed that one.
Fixed the contrast issue by changing the highlighted background color with Surface0. ^^

@nekowinston
Copy link
Member

@Xurdejl will you transfer the repo to catppuccin/infinity ?

@nekowinston
Copy link
Member

Thanks for transferring it! 馃帀
I've updated your permissions for the repo, and I'll add it to the main README.

@unseen-ninja
Copy link
Member

One tiny thing: We want the repo name to be the simplest version of the app, right? So I'd advocate for renaming it to just 禄Infinity芦? c:

@nekowinston
Copy link
Member

Yeah, I was kinda wondering about that, could it clash with anything else named infinity? Otherwise I agree.

@unseen-ninja
Copy link
Member

Yeah, I was kinda wondering about that, could it clash with anything else named infinity? Otherwise I agree.

Likely, but that could potentially be the case for a lot of repos, no?

@nekowinston
Copy link
Member

@Xurdejl I'll rename it to infinity, tweak the links in your README, and add it to the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port request Port Catppuccin to this app
Projects
None yet
Development

No branches or pull requests

5 participants