Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-dash #2351

Closed
1 task done
isabelroses opened this issue Apr 5, 2024 · 2 comments · Fixed by #2378
Closed
1 task done

gh-dash #2351

isabelroses opened this issue Apr 5, 2024 · 2 comments · Fixed by #2378
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer

Comments

@isabelroses
Copy link
Member

isabelroses commented Apr 5, 2024

Link to repository

https://github.com/isabelroses/gh-dash

Screenshots

img

Any additional comments?

No response

Submission Guidelines

  • I have read and followed Catppuccin's submission guidelines.
@rubyowo

This comment was marked as off-topic.

@sgoudham sgoudham changed the title Name of the application/tool/website/etc. gh-dash Apr 5, 2024
@sgoudham
Copy link
Contributor

Hey 👋, looks great and thanks for taking the time to create the repository!

Two comments from me:

  1. I think it'd be nicer to name the files as catppuccin-<flavour>-<accent>.yml instead of the accent.yml. Mostly because I think it's much more descriptive when downloading to the filesystem and saves the user having to rename it, and you also avoid rename popups/accidental overwrites if you're downloading files from multiple flavours. Let me know what you think.
  2. We should honestly avoid the whole "Clone this repository" as a first step going forward lol, I'd keep the usage/installation section just your second bullet point about choosing and downloading a file from the themes directory.

In any case, they're minor comments so happy to approve!

Please read, "Transferring a repository owned by your personal account", if you are unsure about the process of transferring the repository to Catppuccin.

We'll close this issue once the port has been added to our ports.yml.

@sgoudham sgoudham added the waiting for transfer Waiting on the repository being transferred from the maintainer label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants