Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibre #2367

Closed
1 task done
42Willow opened this issue Apr 17, 2024 · 5 comments · Fixed by #2383
Closed
1 task done

Calibre #2367

42Willow opened this issue Apr 17, 2024 · 5 comments · Fixed by #2383
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer

Comments

@42Willow
Copy link
Member

Link to repository

https://github.com/42willow/calibre

Screenshots

image

Any additional comments?

#1854

First port :o

Submission Guidelines

  • I have read and followed Catppuccin's submission guidelines.
@uncenter
Copy link
Member

uncenter commented Apr 17, 2024

I wonder if it is worth theming the icons as well? Obviously not a priority but it would be neat. Looks like they are SVGs so hopefully not too difficult!

Here is the docs on it: https://manual.calibre-ebook.com/customize.html#creating-your-own-icon-theme-for-calibre.
Folder containing default icons: https://github.com/kovidgoyal/calibre/tree/master/imgsrc.

@42Willow
Copy link
Member Author

42Willow commented Apr 17, 2024

Ok, I'll give this a go. Do you know of any efficient method of doing this in batch either automatically or manually with inkscape? If not that's fine, I've got a lot of clicking to do.

Do you think it would better to retain the gradients in the icons or get rid of them?

@uncenter
Copy link
Member

uncenter commented Apr 17, 2024

Ok, I'll give this a go. Do you know of any efficient method of doing this in batch either automatically or manually with inkscape? If not that's fine, I've got a lot of clicking to do.

Hmm I mean I have a tool called ctpvert that attempts to find the closest Catppuccin color but for best results I would do it manually.

Do you think it would better to retain the gradients in the icons or get rid of them?

I'm in favor of getting rid of the gradients :)

@sgoudham
Copy link
Contributor

Hey 👋
Thanks for your work!

I've got a few comments:

  1. I think it would be good to add the icons/dist folder to a .gitignore file as the icons are generated by a makefile and not needed in source control.
  2. I feel like it'd be nicer to rename the theme files as catppuccin-<flavour>-<accent>.calibre-palette instead of just <accent>.calibre-palette. I know I'd much prefer downloading the former into my filesystem (and also prevents rename popups if you're downloading multiple accents/flavours)
  3. The Base key should be set to base instead of mantle as I assume that this is the main background. For further details on how base/mantle should be used in accordance with our other ports, see my comments on the Gitkraken issue (i.e main background as base and sidebars/sidepanels as mantle)

@sgoudham sgoudham added waiting on author Waiting on action from the maintainer and removed waiting on author Waiting on action from the maintainer labels Apr 27, 2024
@sgoudham
Copy link
Contributor

Discussed on discord with @42Willow, port looks good and thanks for implementing my above suggestions!

I'm happy for it to be transferred over to the organisation! Check your inbox for an invite to the Catppuccin GitHub organisation.

Please read, "Transferring a repository owned by your personal account", if you are unsure about the process of transferring the repository to Catppuccin.

We'll close this issue once the port has been added to our ports.yml.

@sgoudham sgoudham added the waiting for transfer Waiting on the repository being transferred from the maintainer label Apr 30, 2024
@sgoudham sgoudham linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants