Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixplorer #2392

Closed
1 task done
auriafoxgirl opened this issue May 8, 2024 · 10 comments · Fixed by #2427
Closed
1 task done

mixplorer #2392

auriafoxgirl opened this issue May 8, 2024 · 10 comments · Fixed by #2427
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer

Comments

@auriafoxgirl
Copy link

Link to repository

https://github.com/auriafoxgirl/mixplorer

Screenshots

meow

Any additional comments?

meow

Submission Guidelines

  • I have read and followed Catppuccin's submission guidelines.
@soymadip
Copy link

Hello, when will this get merge?

@backwardspy
Copy link
Member

Hello, when will this get merge?

@soymadip have you tested this, or if not are you able to? if so, could you offer some thoughts on your experience with it? that would actually help the review process quite a bit!

in the meantime @auriafoxgirl, thanks for your contribution! i have some comments about the repo itself:

  1. the stars/issues/contributors badges at the top of the readme should link to catppuccin/mixplorer (they won't work until the repo is transferred, but that's fine)
  2. the readme heading Genering all theme flavors and accentd s with script yourself has some typos
  3. requiring both lua and python to build the theme is a lot, can this be simplified? my suggestions would be to implement the lua parts in python, or take a look at whiskers
    • as part of this, consider building the theme from our palette.json instead of duplicating the palette data. (if you use whiskers, this step isn't necessary)

that's all for now, let me know what you think.

@auriafoxgirl
Copy link
Author

fixed badges at top and typos
im unsure if whiskers is able to put things automatically into zip with .mit extention, i could try rewriting lua parts in python

@auriafoxgirl
Copy link
Author

Oh and i wanted to ask about palette.json should i just include it in repository?

@backwardspy
Copy link
Member

backwardspy commented Jun 12, 2024

yeah the zip part would have to be a separate step, whiskers won't do that itself.

if you do want to try doing it in python, you can either include palette.json in the repo or depend on the catppuccin python library which exposes the contents of that json as python code. the library is generated from the palette, so if the palette ever changes then updating your port is as simple as updating the dependency and running the code again.

side note: if all these changes end up being a pain for any reason just let me know; they are not blockers, only suggestions. :)

@auriafoxgirl
Copy link
Author

Done! Now it uses python only and catppuccin python library

@backwardspy
Copy link
Member

nice work! that looks really good. i have one more suggestion to make, then i think we'd be happy to accept this port.

rather than keeping the zips tracked in the repo itself, we'd prefer to upload them as release artifacts instead. that way cloning the repo doesn't pull down all the historical build artifacts, while keeping downloads easy for our users.

once you've made that change, let me know and i'll send you an org invite!

@soymadip
Copy link

Hello, when will this get merge?

@soymadip have you tested this, or if not are you able to? if so, could you offer some thoughts on your experience with it? that would actually help the review process quite a bit!

in the meantime @auriafoxgirl, thanks for your contribution! i have some comments about the repo itself:

1. the stars/issues/contributors badges at the top of the readme should link to `catppuccin/mixplorer` (they won't work until the repo is transferred, but that's fine)

2. the readme heading `Genering all theme flavors and accentd s with script yourself` has some typos

3. requiring both lua and python to build the theme is a lot, can this be simplified? my suggestions would be to implement the lua parts in python, or take a look at [whiskers](https://github.com/catppuccin/whiskers)
   
   * as part of this, consider building the theme from our [palette.json](https://github.com/catppuccin/palette/blob/main/palette.json) instead of duplicating the palette data. (if you use whiskers, this step isn't necessary)

that's all for now, let me know what you think.

Oh yeah, i installed the mocha-lavender one before but will install all of them, then will say...

@auriafoxgirl
Copy link
Author

nice work! that looks really good. i have one more suggestion to make, then i think we'd be happy to accept this port.

rather than keeping the zips tracked in the repo itself, we'd prefer to upload them as release artifacts instead. that way cloning the repo doesn't pull down all the historical build artifacts, while keeping downloads easy for our users.

once you've made that change, let me know and i'll send you an org invite!

done now download is in releases

@backwardspy
Copy link
Member

Oh yeah, i installed the mocha-lavender one before but will install all of them, then will say...

@soymadip no need, if you've installed one without issue then that's good enough for me! i just like somebody other than the creator to give it a test just to double check for any issues that might have been passed over.

done now download is in releases

@auriafoxgirl awesome, looks great! i have sent you an invite to the organisation. once you have accepted it, you may transfer the repository as catppuccin/mixplorer. please refer to transferring a repository owned by your personal account if you are not familiar with this process.

we will close this issue when the port has been added to our ports.yml. you can find an example of this in #2378.

@sgoudham sgoudham added the waiting for transfer Waiting on the repository being transferred from the maintainer label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants