-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixplorer #2392
Comments
Hello, when will this get merge? |
@soymadip have you tested this, or if not are you able to? if so, could you offer some thoughts on your experience with it? that would actually help the review process quite a bit! in the meantime @auriafoxgirl, thanks for your contribution! i have some comments about the repo itself:
that's all for now, let me know what you think. |
fixed badges at top and typos |
Oh and i wanted to ask about |
yeah the zip part would have to be a separate step, whiskers won't do that itself. if you do want to try doing it in python, you can either include side note: if all these changes end up being a pain for any reason just let me know; they are not blockers, only suggestions. :) |
Done! Now it uses python only and catppuccin python library |
nice work! that looks really good. i have one more suggestion to make, then i think we'd be happy to accept this port. rather than keeping the zips tracked in the repo itself, we'd prefer to upload them as release artifacts instead. that way cloning the repo doesn't pull down all the historical build artifacts, while keeping downloads easy for our users. once you've made that change, let me know and i'll send you an org invite! |
Oh yeah, i installed the mocha-lavender one before but will install all of them, then will say... |
done now download is in releases |
@soymadip no need, if you've installed one without issue then that's good enough for me! i just like somebody other than the creator to give it a test just to double check for any issues that might have been passed over.
@auriafoxgirl awesome, looks great! i have sent you an invite to the organisation. once you have accepted it, you may transfer the repository as we will close this issue when the port has been added to our ports.yml. you can find an example of this in #2378. |
Link to repository
https://github.com/auriafoxgirl/mixplorer
Screenshots
Any additional comments?
meow
Submission Guidelines
The text was updated successfully, but these errors were encountered: