Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching from light to dark theme using t t made undoable change to the accent of bold + italics accent ( using ***text***) and the accent of header tools. #34

Closed
SumirSeth opened this issue Mar 14, 2024 · 4 comments

Comments

@SumirSeth
Copy link

I was previewing themes using the t t shortcut but it caused colors to swap, mainly the accent color of the bold+underline texts and the tool section in the headerbar.
I have tried reinstalling the theme and refreshing logseq but nothing works. Please help!
image

@SumirSeth SumirSeth changed the title switching from light to dark theme using t t made undoable change to the accent of bold + italics accent ( using ***text***) and the accent of header tools. switching from light to dark theme using t t made undoable change to the accent of bold + italics accent ( using ***text***) and the accent of header tools. Mar 14, 2024
@griimick
Copy link
Member

griimick commented Mar 16, 2024

I checked the latest version of the theme. It is the same as what you have in the screenshot. It is possible that you were using an older version of the theme and it got updated or it was somehow misconfigured.

  • Was bold+italics text getting accent color by default?
  • Were the tool icons in the tool section of the header behaving the same as the other icons (forward, backward, show/hide sidebar) i.e. without accent color?

I am not sure about bold+italics behavior as no change has been made related to that in the theme recently, the toolbar might have broken in the recent changes. I can add that as an action item for this issue report.

@SumirSeth
Copy link
Author

  • yes, bold+italics was getting that accent by default and i did not change anything to specially add colors to it.
  • there is no behavioural change of the header tools with or without acccent.

It could be that it was somehow misconfigured previously and changing the theme somehow "refreshed" it, but I feel like it does not make sense to have accent in the header icons when the home icon, sidebar icon and forward/backward arrows dont have an accent to them. It just adds inconsistency in my opinion.

While I also think that adding accent to the bold+italic text would be a great addition but that is ofc up to personal preferences of the devs.

@griimick
Copy link
Member

griimick commented Mar 16, 2024

Thank you! I agree with both the points. Will add them as action items.

@SumirSeth
Copy link
Author

thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants