Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration with dropbar.nvim #503

Closed
Bekaboo opened this issue Jun 4, 2023 · 5 comments · Fixed by #536
Closed

Better integration with dropbar.nvim #503

Bekaboo opened this issue Jun 4, 2023 · 5 comments · Fixed by #536
Labels
enhancement New feature or request

Comments

@Bekaboo
Copy link

Bekaboo commented Jun 4, 2023

Is your feature request related to a problem? Please describe.

Hi, first of all thanks for all work and devotion in catppuccin!

dropbar.nvim just added a few new highlight groups: hl-DropBarMenuHoverEntry, hl-DropBarMenuHoverIcon, and hl-DropBarMenuHoverSymbol, where the latter two have their default attributes set to reverse = true and bold = true but are not linked to existing highlight groups, thus need to be set explicitly in the colorscheme plugin to avoid to be cleared when toggling background or switching among colorschemes.

  • hl-DropBarMenuHoverEntry provides the background of the current entry under cursor/mouse and is linked to hl-Visual by default:
    image
  • hl-DropBarMenuHoverIcon is used to highlight the icon under the cursor/mouse:
    image
  • hl-DropBarMenuHoverSymbol is used to highight the symbols under the cursor/mouse that have texts:
    image

Describe the solution you'd like

Set highlights for hl-DropBarMenuHoverIcon and hl-DropBarMenuHoverSymbol in catppuccin.

Describe alternatives you've considered

Additional context

@Bekaboo Bekaboo added the enhancement New feature or request label Jun 4, 2023
@Bekaboo
Copy link
Author

Bekaboo commented Jun 4, 2023

Thanks for quick response!

@nullchilly
Copy link
Member

I think you can add a dropbar's ColorScheme event to automatically restore this?

@Bekaboo
Copy link
Author

Bekaboo commented Jun 4, 2023

Yeah that's a solution but that will make it impossible to override these hlgroups if users do not like the default settings.

@nullchilly
Copy link
Member

nullchilly commented Jun 4, 2023

I mean that's what { default = true } is for right?

From :h hi-default

					*:hi-default* *:highlight-default*
The [default] argument is used for setting the default highlighting for a
group.	If highlighting has already been specified for the group the command
will be ignored.  Also when there is an existing link.

Seems like you are already using it though.

@Bekaboo
Copy link
Author

Bekaboo commented Jun 4, 2023

I mean that's what { default = true } is for right?

Didn't realize that default=true can be used to prevent setting an existing hlgroup, I only knew that is can be used to set hlgroups that allows overriding before. Thanks for your kind suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants