Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telescope): telescope flat style support #521

Merged
merged 6 commits into from
Jun 24, 2023
Merged

feat(telescope): telescope flat style support #521

merged 6 commits into from
Jun 24, 2023

Conversation

nottyl
Copy link
Contributor

@nottyl nottyl commented Jun 24, 2023

Updates the Telescope integration to allow users to choose a telescope style between "nvchad" and "classic".
The default style currently is set to "classic"

  • Classic (the original style):
Screenshot 2023-06-24 at 11 46 38
  • Nvchad (flat style)
Screenshot 2023-06-24 at 11 47 07

@nullchilly
Copy link
Contributor

Please keep backwards compatibility, O.integrations.telescope was a boolean before and can't be indexed

The default should be classic since we respect plugin's theme guideline

I think we should rename flat -> nvchad since it's the original

image

@nottyl
Copy link
Contributor Author

nottyl commented Jun 24, 2023

Ok! I changed the name flat to nvchad and included backward compatibility in the latest commit. Though I don't know how to implement backward compatibility correctly so the code might be a bit ugly :<

Copy link
Collaborator

@mrtnvgr mrtnvgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mrtnvgr mrtnvgr merged commit fc73faa into catppuccin:main Jun 24, 2023
9 checks passed
@nottyl nottyl deleted the telescope-flat-style branch June 24, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants