vim-illuminate better highlight groups

[andy941]

Is your feature request related to a problem? Please describe.
vim-illuminate can display different colors for variable definition/usage which helps reason about code quite a lot better

Describe the solution you'd like
Integrate the highlight groups in the colorscheme

Describe alternatives you've considered
Define them manually but I think this should come with the colorscheme

Additional context
The highlight groups. The *Read and *Write highlight groups are the ones that get used when LSP information is available.

P.S.: the colorscheme is amazing, good job!

[nekowinston]

illuminate should be supported, see our integrations table:

equire("catppuccin").setup({
    integrations = {
      illuminate = true,
    }
})

#283 was closed by b4526a7

[andy941]

Hi, I saw that and I have set illuminate=true, what I meant that the colors for the three highlight group are the same at the moment so even if there is an LSP active, there is no difference between definition and use of a variable. See the example below.

int var = 0 // var background should have one color (var defined here)
var = 4; // another color
var = 3; // same color as line above

Of course background colors olny show when you hover var.

[nullchilly]

The problem is it's hard to come up with an another color that would please everyone.

Maybe TextRead will have underline? Maybe TextWrite should use standout style? Dunno. If you can suggest your desire highlight definition I will happily add it under illuminate.lsp option.

[andy941]

I see your point. Personally I used inverse colors (background and foreground colors inverted) for the definition because I wanted it to stand out as much as possible but even a different shade of grey would be fine I think ( darker for light theme an lighter for dark theme). A different shade would probably please most people, especially if the lsp behavior can be toggled.

[nullchilly]

What about the difference between IlluminatedWordRead and IlluminatedWordWrite, or do you keep them the same?

[andy941]

Ideally Text Should be white background and high visibility, like Write, while Read have a grey background. However, Text highlight is used by default when there is no LSP active for every occurrence of the word and I don't like to have such a strong background in that case, it's too distracting. It's probably a good compromise to have. Text and Read grey and Write in white background.