Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feline): fix feline integration #685

Merged
merged 2 commits into from Mar 26, 2024
Merged

feat(feline): fix feline integration #685

merged 2 commits into from Mar 26, 2024

Conversation

89iuv
Copy link
Collaborator

@89iuv 89iuv commented Mar 26, 2024

This PR is intended to fix the feline integration by:

  • changing the background color from mantle to surface0 which is the actual color used in the pictures
  • enable the user to use the setup function without any parameter as described in the documentation

Visual changes:
Old:
image

New:
image

Reference:

…l pictures, enable the use of the setup function without the need of an object
@sgoudham
Copy link
Contributor

sgoudham commented Mar 26, 2024

We're using crust bars across VSCode/JetBrains now afaik so I believe the picture should be updated instead of reverting back to surface0

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, the neovim screenshot should be updated to have the crust bar

lua/catppuccin/groups/integrations/feline.lua Outdated Show resolved Hide resolved
lua/catppuccin/groups/integrations/feline.lua Show resolved Hide resolved
@89iuv
Copy link
Collaborator Author

89iuv commented Mar 26, 2024

Lookin at the VScode repo i see that we are using Crust for the status bar, not mantle.

The problem that i am trying to fix is that in nvim the status bar and the file explorer have the same background color making them blend on into the other and not providing a clear visual distinction between the two of them.

I think if we want to keep consistency across catppuccin editors then maybe crust would be a better fit:
image

@sgoudham
Copy link
Contributor

Ah yes, good catch! Crust sounds good for consistency with VSCode. @89iuv

Co-authored-by: Hammy <58985301+sgoudham@users.noreply.github.com>
@89iuv 89iuv requested a review from sgoudham March 26, 2024 08:52
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the colours, don't want to block the merge on screenshots so we can update them at a later time 👍

@mrtnvgr mrtnvgr merged commit 07679af into main Mar 26, 2024
11 checks passed
@89iuv 89iuv deleted the fix-feline-integration branch March 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants