Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puccinier-V2: Move to toolbox #12

Merged
merged 22 commits into from Sep 7, 2022
Merged

Puccinier-V2: Move to toolbox #12

merged 22 commits into from Sep 7, 2022

Conversation

sgoudham
Copy link
Contributor

@sgoudham sgoudham commented Sep 5, 2022 •
edited by ap-1

Description

Ports puccinier v2 to the toolbox repository

Blockers

  • Waiting on licenses to comply with catppuccin organisation guidelines

Resolves #1

Resolves #3

@sgoudham sgoudham added the do not merge Do not merge this pull request label Sep 5, 2022
sgoudham
sgoudham commented Sep 5, 2022
View reviewed changes
puccinier/LICENSE-MIT Outdated Show resolved Hide resolved
sgoudham
sgoudham commented Sep 5, 2022
View reviewed changes
puccinier/LICENSE-APACHE Outdated Show resolved Hide resolved
Anish Pallati and others added 2 commits September 5, 2022 23:53
@sgoudham
docs: Update puccinier/LICENSE-MIT
d885ead 
Co-authored-by: Hamothy <58985301+sgoudham@users.noreply.github.com>
@sgoudham
chore: Update puccinier/LICENSE-APACHE
07855ef 
Co-authored-by: Hamothy <58985301+sgoudham@users.noreply.github.com>
@ap-1 ap-1 marked this pull request as ready for review September 5, 2022 23:54
@ap-1
Copy link

ap-1 commented Sep 5, 2022

Meant to label the second commit with docs instead of chore but it's whatever. This should be ready for review now

@nekowinston
Copy link
Member

Thank you @ap-1! Both for the amazing work on the tool and re-licensing it. ❤️

@sgoudham sgoudham removed the do not merge Do not merge this pull request label Sep 7, 2022
@sgoudham sgoudham self-assigned this Sep 7, 2022
nekowinston
nekowinston approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@nekowinston nekowinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekowinston nekowinston merged commit a27dd6e into main Sep 7, 2022
@nekowinston nekowinston deleted the puccinier-v2 branch September 7, 2022 23:16
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekowinston nekowinston nekowinston approved these changes

Assignees

@sgoudham sgoudham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Puccinier is case sensitive Puccinier: Conversion from v1 palette
3 participants
@sgoudham @ap-1 @nekowinston