Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mastodon "System" theme #966

Closed
2 tasks done
cyrneko opened this issue Jun 7, 2024 · 6 comments · Fixed by #1074
Closed
2 tasks done

Support Mastodon "System" theme #966

cyrneko opened this issue Jun 7, 2024 · 6 comments · Fixed by #1074
Labels
mastodon Mastodon needs reproduction Unable to reproduce, more details needed

Comments

@cyrneko
Copy link

cyrneko commented Jun 7, 2024

Is there an existing issue outlining your problem?

  • I am using the latest version of the provided userstyle.
  • I have searched the existing issues and they do not solve my problem.

What userstyles are you seeing the problem on?

lbl:mastodon

Describe your problem.

With recent changes to Mastodon they have introduced an option to automatically change dark/light themes. Sadly, this is not backwards-compatible with the "Mastodon Light" and "Mastodon Dark" themes which's variables where used before.

Attach screenshots.

image

What browser(s) are you seeing the problem on?

Any, but I use LibreWolf 126.0

Any additional comments?

N/A

@github-actions github-actions bot added the mastodon Mastodon label Jun 7, 2024
@uncenter
Copy link
Member

uncenter commented Jul 9, 2024

As illustrated in your screenshot, this doesn't seem like a "recent change to Mastodon" and more something your Glitch instance added that isn't universal across all Mastodon sites. For example, I'm not seeing this on fosstodon.org.

@isabelroses
Copy link
Member

I cannot seem to reproduce on tech.lgbt

image

@cyrneko
Copy link
Author

cyrneko commented Jul 12, 2024

As illustrated in your screenshot, this doesn't seem like a "recent change to Mastodon" and more something your Glitch instance added that isn't universal across all Mastodon sites. For example, I'm not seeing this on fosstodon.org.

No, this is an official Mastodon change. My instance recently merged upstream when I made the issue.

mastodon/mastodon@02ea161

@uncenter
Copy link
Member

Sure, but I still can't reproduce so I can't make a fix.

@uncenter uncenter added the needs reproduction Unable to reproduce, more details needed label Jul 12, 2024
@isabelroses
Copy link
Member

I can write a patch for this based of the source shared, cannot test it though!

@cyrneko
Copy link
Author

cyrneko commented Jul 13, 2024

I can write a patch for this based of the source shared, cannot test it though!

image

Seems to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mastodon Mastodon needs reproduction Unable to reproduce, more details needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants