Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Does the latest version contain icons from my work? #78

Closed
thang-nm opened this issue Jan 27, 2024 · 3 comments · Fixed by #86
Closed

[Question] Does the latest version contain icons from my work? #78

thang-nm opened this issue Jan 27, 2024 · 3 comments · Fixed by #86
Labels
question Further information is requested

Comments

@thang-nm
Copy link

thang-nm commented Jan 27, 2024

My icons: Catppuccin-Perfect-Icons

@thang-nm thang-nm added the enhancement New feature or request label Jan 27, 2024
@prazdevs prazdevs added question Further information is requested and removed enhancement New feature or request labels Jan 27, 2024
@prazdevs
Copy link
Member

prazdevs commented Jan 27, 2024

Hi :)

When doing v1, I reworked all the icons, and learnt from your work that 16x16 icons work better (since vsc rasterizes to 32x32). I also took some icons we didn't have and reworked them to better fit the set of guidelines. Besides icons, I reworked a lot of the extension code to include customization through VSCode's API (we now have the first customization feature available!)

I'd have loved to have you contribute upstream to the main repository, you're still welcome to do it!

It was an oversight not including copyright/license notice, I didn't see it as a necessity since the fork was originally based on what I did and edited, I shall raise a PR for it to address LICENSE and thanks section.

Also this repositry aims to become an icon only repo (the extension-related code will be moved to a separate repo), and will probably be much more explicit about licensing (some language/company icons being based on proprietary/licensed things), see simple-icons as example.

Feel free to also join the Discord to talk about it!

Thanks for being understanding. 😌

@thang-nm
Copy link
Author

thang-nm commented Jan 28, 2024

After spending time recreating over 300 icons from version 0.21.0, I added many more icons. I spent a lot of time finding ideas, as well as how to make them display well on non-retina screens, so I would be very happy if you could add to LICENSE and thanks section as you said.
Thank you so much 🎉

@prazdevs
Copy link
Member

done! 😄

feel free to contribute to the main repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants