Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add option to disable bold text #55

Closed
piotrwieckiewicz opened this issue Oct 28, 2022 · 9 comments · Fixed by #58
Closed

[Feature request] Add option to disable bold text #55

piotrwieckiewicz opened this issue Oct 28, 2022 · 9 comments · Fixed by #58

Comments

@piotrwieckiewicz
Copy link

Similarly to option to disable italics which was added recently, maybe a good idea was to add option to disable bold text?
In some languages there are a lot of bold text

image

@nekowinston
Copy link
Contributor

Sure thing, I'll work on it!

@nekowinston
Copy link
Contributor

@piotrwieckiewicz I have added it, and just rolled a new release. Should be on the marketplace in a couple of minutes.

@piotrwieckiewicz
Copy link
Author

piotrwieckiewicz commented Oct 28, 2022

@nekowinston Wow, thank you for such a quick fix and creating such an amazing theme!

Unfortunately, it does not work for me. If I write code in Scala, bold keywords are still a thing - even after disabling bold font in settings. I don't know, maybe thats something language-specific, although it happens ONLY with Catppuccin. In every other theme keywords are not bold.
Strange, so bear in mind that it does not work in every case. There might be more edge cases like this

@nekowinston
Copy link
Contributor

nekowinston commented Oct 28, 2022

Could you please try to toggle the setting again?

The settings toggle (and the re-compilation it triggers) is pretty new, and I wouldn't be surprised if that's the cause of the issue.

@nekowinston nekowinston reopened this Oct 28, 2022
@piotrwieckiewicz
Copy link
Author

@nekowinston There is something wrong here, but I am not sure what exactly. Toggle sometimes turn bold font on of off, but sometimes it does not. And turning italics on/off sometimes breaks bold. For instance, if you have bold font turned on and if you start toggling italics, bold font might turn. It does not seems consistent, but you can create a situation where bold font is present in code, but in option it is not (and vice versa)

@nekowinston
Copy link
Contributor

Yeah I just had a look at your example myself, it's definitely the compile step. I'll have a look at this again tomorrow.
image
image

@piotrwieckiewicz
Copy link
Author

Good to know I'm not going crazy :D
Thanks!

@nekowinston
Copy link
Contributor

Tracking this in #61, will roll a release later.

@nekowinston
Copy link
Contributor

Just following up here @piotrwieckiewicz, I just closed #61, I hope I found the main problem. Please let me know if the compile step works for you now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants