Catty-77: Migrate UIWebView to WKWebView

[neel-makhecha]

Updated UIWebView to WKWebView in HelpWebViewController.swift along with all delegates.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

• Include the name of the Jira ticket in the PR’s title
• Verify that the Jira ticket is in the status Ready for Development
• Include a summary of the changes plus the relevant context
• Choose the proper base branch (develop)
• Confirm that the changes follow the project’s coding guidelines
• Verify that the changes generate no compiler or linter warnings
• Perform a self-review of the changes
• Verify to commit no other files than the intentionally changed ones
• Include reasonable and readable tests verifying the added or changed behavior
• Confirm that new and existing unit tests pass locally
• Check that the commits’ message style matches the project’s guideline
• Stick to the project’s git workflow (rebase and squash your commits)
• Verify that your changes do not have any conflicts with the base branch
• After the PR, verify that all CI checks have passed
• Post a message in the #catty Slack channel and ask for a code reviewer

[m-herold]

Jenkins, retest this please.

[m-herold]

Thanks! I left a few (minor) suggestions directly at the affected lines of code. One major thing we need to address:

• Click on "Help"
• Click on the "hamburger" menu button
• Click on Featured
• Select any project
• Click on "Download the project"
• The app is crashing: *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Completion handler passed to -[Pocket_Code.HelpWebViewController webView:decidePolicyForNavigationAction:decisionHandler:] was called more than once'

[neel-makhecha]

Hi Michael
I have implemented changes as suggested. Please review it.

[m-herold]

Were you able to reproduce the NSInternalInconsistencyException as mentioned above?

[neel-makhecha]

Were you able to reproduce the NSInternalInconsistencyException as mentioned above?

Yes, I was getting that exception but with a different reason
'NSInternalInconsistencyException', reason: 'Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread.'

The exception with the reason you mentioned is fixed with a return statement in decidePolicyFor navigationAction , where it was calling completion handler more than once in certain conditions.

Another exception that I mentioned above is fixed with various changes in the way progressBar gets hidden and unhidden, when the activityIndicator is visible.

[neel-makhecha]

Hi Michael,
I have made changes as per your suggestions and have made some more where required. Please review it.

[neel-makhecha]

I'm sorry, I have a very bad habit of force unwrapping optionals. I have updated tests again fixing that.

[neel-makhecha]

Hi Michael,
I have made changes as per your suggestions. Please review it.

[m-herold]

When you test your implementation having internet turned off (or when running into a timeout), the corresponding alert is never shown and the loading view keeps spinning for ever. For this time please do not directly squash your commits but please add another commit (makes review of the large class easier). Thanks!

[m-herold]

The app is still crashing after downloading a project from within the WKWebView. See one of my previous comments on how to reproduce (stay in the view for another ~10 seconds or so without doing anything).

[m-herold]

@neel-makhecha any news on that pull request? thanks!

[neel-makhecha]

@neel-makhecha any news on that pull request? thanks!

Yes! The first issue where the loading view kept spinning forever is resolved. I had implemented an incorrect delegate method. So that's solved. But I am still trying to figure out the the crash. I am currently working on that, it is occasional and don't happen every time. But hopefully will figure out that too very soon!

[neel-makhecha]

Hi Michael,
I have done the changes addressing those issues. Please review.

[m-herold]

Thank you, looks very good! Please squash your commits, then this pull request is ready to merge.

[neel-makhecha]

Done!