Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATTY-333 Use StoreProjectUploader in UploadViewController #1405

Merged
merged 1 commit into from Jul 15, 2020
Merged

CATTY-333 Use StoreProjectUploader in UploadViewController #1405

merged 1 commit into from Jul 15, 2020

Conversation

DhrubojyotiBis1
Copy link
Contributor

  • Used StoreProjectUploader in UploadViewController
  • Removed deprecated for uploading from UploadViewController

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

m-herold
m-herold requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@m-herold m-herold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test, ideally by injecting a test double for the uploader and executing the uploadAction to verify whether the proper method of the uploader is being called (please do not actually upload the project).

src/Catty/ViewController/Upload/UploadViewController.swift Outdated Show resolved Hide resolved
src/Catty/ViewController/Upload/UploadViewController.swift Outdated Show resolved Hide resolved
src/Catty/ViewController/Upload/UploadViewController.swift Outdated Show resolved Hide resolved
@DhrubojyotiBis1
Copy link
Contributor Author

Hi, @m-herold I have made the changes. Please review

@DhrubojyotiBis1
Copy link
Contributor Author

Hi, @m-herold I have made the changes. Please review

@DhrubojyotiBis1
Copy link
Contributor Author

Hi @m-herold Jenkin test fails due to junit report not found.

@m-herold
Copy link
Member

Jenkins, retest this please.

@DhrubojyotiBis1
Copy link
Contributor Author

Hi, @m-herold I have updated the PR. Please review

@m-herold
Copy link
Member

Jenkins, retest this please.

@DhrubojyotiBis1 DhrubojyotiBis1 force-pushed the CATTY-333 branch 2 times, most recently from 32fe1f7 to f3becb6 Compare July 14, 2020 14:51
@m-herold m-herold merged commit 82cf4d3 into Catrobat:develop Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-herold m-herold m-herold approved these changes

Assignees
No one assigned
Labels
in code review
Projects
None yet
Milestone
No milestone
2 participants
@DhrubojyotiBis1 @m-herold