Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 [Refactor_WebApp] - Change the router #64

Open
1 task done
kailashchoudhary11 opened this issue May 31, 2023 · 4 comments
Open
1 task done

🚀 [Refactor_WebApp] - Change the router #64

kailashchoudhary11 opened this issue May 31, 2023 · 4 comments
Labels
enhancement New feature or request gssoc23 This is label for GirlScript Summer of Code 2023

Comments

@kailashchoudhary11
Copy link

Description of the enhancement. ✍🏻

We can change the router to RouterProvider instead of BrowserRouter this will allow us to use the data APIs like loaders and actions. What do you think 🤔

Describe briefly how you would implement this enhancement.

By importing the required functions and components.

Screenshots Example (if applicable)

No response

Additional information

No response

Contributor terms

  • I agree to follow the Contributing Instructions
@kailashchoudhary11 kailashchoudhary11 added the enhancement New feature or request label May 31, 2023
@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code 2023 label May 31, 2023
@github-actions
Copy link

Hello @kailashchoudhary11!
Thank you for raising this issue.

Please make sure to follow our Contributing Guidelines. 💪🏻
Don't forget to ⭐ our GitHub-ReadMe. 📃

Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience! 😀

@praveenscience
Copy link
Member

praveenscience commented May 31, 2023 •
edited

Why is this better? Coz I tried this and seemed complicated. Also we don't even need Router, I'd say, remove the router?

@kailashchoudhary11
Copy link
Author

Why is this better? Coz I tried this and seemed complicated. Also we don't even need Router, I'd say, remove the router?

Aren't we planning on adding more pages?

@praveenscience
Copy link
Member

What pages are we planning to add? Just thinking about the scope of the project! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gssoc23 This is label for GirlScript Summer of Code 2023
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@praveenscience @kailashchoudhary11