Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling during turns #7

Closed
Catsuko opened this issue Oct 25, 2019 · 1 comment
Closed

Error handling during turns #7

Catsuko opened this issue Oct 25, 2019 · 1 comment
Assignees
@mikepepping
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Catsuko
Copy link
Owner

Catsuko commented Oct 25, 2019

When an error occurs during a player's turn, the game should catch the error and then declare the other player the winner.

Bonus points for printing the reason a player won onto the game view:
"Player 1 won, they connected four!"
"Player 1 won, player 2 tried to place their token out of bounds"
"Player 1 won, player 2 tried to place their token in a full column"
@Catsuko Catsuko added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 25, 2019
@mikepepping mikepepping self-assigned this Oct 27, 2019
@Catsuko
Copy link
Owner Author

Catsuko commented Oct 27, 2019 •
edited

Implemented by @p3pping

@Catsuko Catsuko closed this as completed Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikepepping mikepepping

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Catsuko @mikepepping