Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename pull_policies to pull_policy in config.toml #1084

Merged
merged 11 commits into from Feb 15, 2024

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Feb 8, 2024

Description

The runner_worker_docker_options mentioned a pull_policies attribute which was directly used in config.toml which is wrong. The correct name is pull_policy. pull_policy is ignored by the Runner and has no effect. Instead a pull policy of always is used automatically.

This PR renames the pull_policies to pull_policy before inserting it into the configuration file. If pull_policies is used at the moment it has no effect.

Closes #1065

Migrations required

In case var.runner_worker_docker_options.pull_policy is used, rename pull_policy to pull_policies and make sure that it is a list(string), e.g. pull_policies = ["always"]

Verification

Still to be done

  • pull_policies not given --> `pull_policy = ["always"] is used.
  • pull_policies given --> Specified value used

@kayman-mk kayman-mk requested a review from npalm as a code owner February 8, 2024 16:13
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.85s
✅ REPOSITORY checkov yes no 16.75s
✅ REPOSITORY dustilock yes no 0.35s
✅ REPOSITORY gitleaks yes no 1.16s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 14.02s
✅ REPOSITORY secretlint yes no 1.32s
✅ REPOSITORY syft yes no 0.28s
✅ REPOSITORY trivy-sbom yes no 1.46s
✅ REPOSITORY trufflehog yes no 11.11s
✅ SPELL cspell 5 0 3.29s
✅ TERRAFORM terraform-fmt 3 0 0 0.43s
✅ TERRAFORM terragrunt 1 0 0 0.31s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk
Copy link
Collaborator Author

I think the above code makes no sense at all. Better to rename pull_policies before inserting it into the configuration file. This way we know that it accepts a list of strings as pull_policy implies one value only (at least for me).

@kayman-mk kayman-mk changed the title fix: rename pull_policies to pull_policy fix: rename pull_policies to pull_policy in config.toml Feb 10, 2024
@kayman-mk kayman-mk merged commit df39014 into main Feb 15, 2024
19 checks passed
@kayman-mk kayman-mk deleted the kayma/pull_policy branch February 15, 2024 09:38
kayman-mk pushed a commit that referenced this pull request Feb 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.4.0](7.3.1...7.4.0)
(2024-02-15)


### Features

* error checking for initial API token call
([#1080](#1080))
([6b3740a](6b3740a))


### Bug Fixes

* rename `pull_policies` to `pull_policy` in `config.toml`
([#1084](#1084))
([df39014](df39014))
* repair errors in startup shell script
([#1087](#1087))
([9b7c465](9b7c465))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with pull_policies
1 participant