New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename pull_policies
to pull_policy
in config.toml
#1084
Conversation
Hey @kayman-mk! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
I think the above code makes no sense at all. Better to rename |
pull_policies
to pull_policy
pull_policies
to pull_policy
in config.toml
🤖 I have created a release *beep* *boop* --- ## [7.4.0](7.3.1...7.4.0) (2024-02-15) ### Features * error checking for initial API token call ([#1080](#1080)) ([6b3740a](6b3740a)) ### Bug Fixes * rename `pull_policies` to `pull_policy` in `config.toml` ([#1084](#1084)) ([df39014](df39014)) * repair errors in startup shell script ([#1087](#1087)) ([9b7c465](9b7c465)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The
runner_worker_docker_options
mentioned apull_policies
attribute which was directly used inconfig.toml
which is wrong. The correct name ispull_policy
.pull_policy
is ignored by the Runner and has no effect. Instead a pull policy ofalways
is used automatically.This PR renames the
pull_policies
topull_policy
before inserting it into the configuration file. Ifpull_policies
is used at the moment it has no effect.Closes #1065
Migrations required
In case
var.runner_worker_docker_options.pull_policy
is used, renamepull_policy
topull_policies
and make sure that it is alist(string)
, e.g.pull_policies = ["always"]
Verification
Still to be done
pull_policies
not given --> `pull_policy = ["always"] is used.pull_policies
given --> Specified value used