Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a valid policy for ssm access #1124

Conversation

ryancausey
Copy link
Contributor

Description

This resolves an issue where the previous policy template did not specify a valid resource argument for the second policy statement. The modified template should now apply without error.

Migrations required

No

Verification

I applied this module to my runner setup and it resolved the issue.

Closes #1123

This resolves an issue where the previous policy template did not
specify a valid resource argument for the second policy statement. The
modified template should now apply without error.
Copy link
Contributor

github-actions bot commented May 8, 2024

Hey @ryancausey! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@kayman-mk
Copy link
Collaborator

Have seen this today as well. Guess we better limit access to the exact resource.

@kayman-mk
Copy link
Collaborator

@ryancausey Could you please have a look at my last commit? I think it is better to not allow the Runner to access all SSM parameters. I know, the * was there before, but I think we should fix this now.

Copy link
Contributor Author

@ryancausey ryancausey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's better to specify the exact parameters the role has access to, but I left a comment about a possible alternative approach to defining the policy JSON that I believe will be easier to follow and maintain.

main.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue.

@kayman-mk kayman-mk merged commit fec8c8a into cattle-ops:main May 10, 2024
19 checks passed
kayman-mk pushed a commit that referenced this pull request May 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.6.1](7.6.0...7.6.1)
(2024-05-10)


### Bug Fixes

* use a valid policy for ssm access
([#1124](#1124))
([fec8c8a](fec8c8a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy template instance-secure-parameter-role-policy.json is invalid
2 participants