Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner token usage counter not decrementing when terminating old instance #1136

Open
long-wan-ep opened this issue Jun 11, 2024 · 0 comments

Comments

@long-wan-ep
Copy link
Contributor

Describe the bug

The usage counter in the runner token SSM parameter is not decrementing when old runner instances are terminated. I feel like remove-gitlab-registration.service is not running on termination, since I don't see the expected "Token still in use. GitLab Runner not removed from GitLab." message in the logs.

To Reproduce

Steps to reproduce the behavior:

  1. Deploy a runner on version 7.7 of the module
  2. Verify the usage counter for the runner token SSM param is 1
  3. Make a update to the runner config that would result in a runner refresh
  4. Wait for graceful terminate to complete and the old runner instance is terminated
  5. Check the usage counter again, which will show 2 instead of 1

Expected behavior

The usage counter should increment when a new runner instance spins up, and decrement when an old runner instance terminates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant