Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the "terminate agent" AWS lambda #631

Open
kayman-mk opened this issue Jan 6, 2023 · 2 comments
Open

Refactor the "terminate agent" AWS lambda #631

kayman-mk opened this issue Jan 6, 2023 · 2 comments
Labels
enhancement 🆕 New feature or request help wanted Extra attention is needed work-in-progress Issue/PR is worked, should not become stale

Comments

@kayman-mk
Copy link
Collaborator

kayman-mk commented Jan 6, 2023

Describe the solution you'd like

During implementation of #628 some questions arose regarding this lambda function:

  • can we update to Python 3.9?
  • can we move to ARM to save costs?
  • the best setting for the memory size?
  • add a logging library (JSON output format)

Analyze these points and create a PR for it.

@kayman-mk kayman-mk added enhancement 🆕 New feature or request help wanted Extra attention is needed labels Jan 6, 2023
@kayman-mk
Copy link
Collaborator Author

kayman-mk commented Jan 9, 2023

Memory vs runtime:

128 MB --> < 20s

Startup time less than 1 second.

Checked several executions in my live account.

@kayman-mk
Copy link
Collaborator Author

python-json-logger seems to be a good library for logging (on top of logging)

@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Apr 20, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Apr 20, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Jun 20, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Jun 20, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Aug 20, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Aug 31, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Oct 31, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Oct 31, 2023
@kayman-mk kayman-mk added the work-in-progress Issue/PR is worked, should not become stale label Nov 16, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆕 New feature or request help wanted Extra attention is needed work-in-progress Issue/PR is worked, should not become stale
Projects
None yet
Development

No branches or pull requests

1 participant