Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump html5ever for removed time methods #74

Closed
bigpick opened this issue Feb 19, 2022 · 4 comments
Closed

Bump html5ever for removed time methods #74

bigpick opened this issue Feb 19, 2022 · 4 comments

Comments

@bigpick
Copy link

bigpick commented Feb 19, 2022

Bug Info

The current of version of html5ever is utilizing sinnce-removed method (precise_time_ns):

error[E0425]: cannot find function `precise_time_ns` in crate `time`
   --> ...../cargo/registry/src/github.com-1ecc6299db9ec823/html5ever-0.5.4/src/macros.rs:27:26
    |
27  |         let t0 = ::time::precise_time_ns();
    |                          ^^^^^^^^^^^^^^^ not found in `time`
    |
   ::: ...../.cargo/registry/src/github.com-1ecc6299db9ec823/html5ever-0.5.4/src/tokenizer/mod.rs:230:27
    |
230 |             let (_, dt) = time!(self.sink.process_token(token));
    |                           ------------------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

edit: looks like

html5ever = "0.25.1"

is still currently the latest published release of html5ever still :\

@cfvescovo
Copy link
Collaborator

We will have to wait for a new version of html5ever to be published. The latest version available on crates.io (at the time of writing, 20220221) is 0.25.1 and was published 2 years ago.

Maybe we should open an issue on servo/html5ever and ask for a new release to be published.

@cfvescovo
Copy link
Collaborator

html5ever 0.26.0 is out!

@cfvescovo
Copy link
Collaborator

I will check if they have made any breaking changes and report back here

@cfvescovo
Copy link
Collaborator

All OK, html5ever bumped to 0.26 in 1509a64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants