Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile touches go through the side bar as well. #5

Closed
SgtBatten opened this issue Jan 3, 2017 · 11 comments
Closed

Mobile touches go through the side bar as well. #5

SgtBatten opened this issue Jan 3, 2017 · 11 comments
Labels

Comments

@SgtBatten
Copy link

Doesn't appear to happen on PC.

On mobile couch potato is my 4th tab down.
I have my side bar pinned.

To reproduce:
Be using any tab.
Press couch potato icon on left. (Loads couch potato to home page and expands side menu)
Close side menu by pressing couch potato text
Side menu will close and couch potato will also change to movies page because the movies link was beneath the side bar where you just clicked.

Presumably this is not unique to couch potato but it's an example that will work every time.

@causefx
Copy link
Owner

causefx commented Jan 3, 2017

is this during landscape?

@SgtBatten
Copy link
Author

Both portrait and landscape are the same

@causefx
Copy link
Owner

causefx commented Jan 3, 2017

hmmmm, I just changed some code so it auto closes if menu is open in landscape. hopefully that fixes it.

@causefx
Copy link
Owner

causefx commented Jan 3, 2017

it also wont auto open menu on mobile if pinned.

@SgtBatten
Copy link
Author

Do you mean after the change?

Currently it's pinned and it automatically expands the side bar when I select a new tab

@causefx
Copy link
Owner

causefx commented Jan 3, 2017

correct, i fixed it on my end, Will push the commit today sometime.

@SgtBatten
Copy link
Author

Doesn't appear to be fixed for me

@causefx
Copy link
Owner

causefx commented Jan 4, 2017

What is the phrase

@SgtBatten
Copy link
Author

Not sure what you mean.

The example from the opening post still happens for me.
Same as my server name still takes up 2 lines. I definitely updated everything.

@SgtBatten
Copy link
Author

Errrgh nevermind. I must have been viewing a cached version. Server name is good and the tabs no longer expand on touch so that means this bug is fixed too. Thanks man

@causefx
Copy link
Owner

causefx commented Jan 4, 2017

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants