Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PowerShell v2, v3 and v4 #24

Open
cavejay opened this issue Jan 15, 2018 · 4 comments
Open

Support for PowerShell v2, v3 and v4 #24

cavejay opened this issue Jan 15, 2018 · 4 comments

Comments

@cavejay
Copy link
Owner

cavejay commented Jan 15, 2018

While running on and with the latest and greatest it's important to support older OS's and versions of Powershell as well, especially when that's all some customers have access too.

Not sure if this should be a separate release, potentially as a cut-down version to begin with or if it should (or can be?) implemented in another 1-for-all method

@cvidler
Copy link

cvidler commented Jan 15, 2018

v1 ?

any critical functionality not available in v1?

@cavejay
Copy link
Owner Author

cavejay commented Apr 4, 2018

@cvidler v1 doesn't have a good/safe config and doesn't support the better sanitising introduced later (specifically how to deal with masses of "Ip x resolved as "

@cavejay cavejay changed the title Support for PowerShell v3 and v4 Support for PowerShell v2, v3 and v4 Apr 6, 2018
@cavejay
Copy link
Owner Author

cavejay commented Apr 8, 2018

Working on this in the https://github.com/cavejay/Strippy/tree/Version-Specifics-and-PowerShell-2/3-compatability branch. All the cmdlets I've used appear to be available in 2.0 but some are behaving differently. List of current compatibility fixes:

  • [regex]::matches() returns some weird as object that needs to be parsed rather than normally used.
  • Tuples don't exist
  • Passing arguments to jobs is not behaving as expected.
    -- I could sacrifice the speed of Strippy's current parallel processing but I consider that one of the major features. Processing file by file just takes too long and this script is all about speed.
  • Enums don't exist so I've just switch to strings
  • $PSScriptRoot didn't exist so I made it
  • Write-progress suddenly requires the -status argument /shrug

Preferably the outcome of the 'legacy' script will be a separate release to the current-release that always maintains compatibility with 2.0. If that can't happen then I'm willing to remove features (that aren't the config loading, logging or jobbing) until it works.

So far the only 1 of those features that's being a headache is the jobbing and I'm currently considering if it's worth the move to runspaces to see if that saves it. That would be a major release with serious code refactoring though and I've not enough time for that.

@cavejay cavejay self-assigned this Apr 10, 2018
@cavejay cavejay added this to Backlog in Strippy General Jun 25, 2018
@cavejay
Copy link
Owner Author

cavejay commented Feb 24, 2020

If a P1 isn't being treated like a P1, it's not a P1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Strippy General
  
Backlog
Development

No branches or pull requests

2 participants