Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert needed for missing file path (art/sound problems) #890

Open
raxo2222 opened this issue Mar 11, 2021 · 2 comments
Open

Assert needed for missing file path (art/sound problems) #890

raxo2222 opened this issue Mar 11, 2021 · 2 comments
Assignees
Labels
bug Something isn't working dll A C++ issue python A Python related issue xml Related to the XML data

Comments

@raxo2222
Copy link
Contributor

raxo2222 commented Mar 11, 2021

Units, buildings, and other stuff have various ART and sound defines.

They lead to art/sound define files, which then reference file path.

When file actually doesn't exist, game should throw asserts.

Example:
ART_DEF_UNIT_TRIBAL_GUARDIAN in units infos
UNIT_TRIBAL_GUARDIAN in unit art style defines
ART_DEF_UNIT_TRIBAL_GUARDIAN in unit art defines
Art/Units/Spikedclub/warrior_fx.nif this file is not found.

Sound:
AS2D_UNIT_BUILD_UNIT in unit art defines
SND_BUILD_UNIT in audio2dscripts
Sounds/Units/BuildUnit this file is not found.

If this chain doesn't end up on file path, then assert would show up earlier, and say: "Malformed art/sound define"

It also can be done for text:
If things referencing TEXT have missing texts, then it also could assert.
Or simply create log file with all art/sound/text reference chains, so we can see in logs what exactly is missing file or text entry in TEXT file.

@raxo2222 raxo2222 added bug Something isn't working xml Related to the XML data python A Python related issue dll A C++ issue labels Mar 11, 2021
@raxo2222 raxo2222 added this to Backlog in Bugs and Asserts via automation Apr 19, 2021
@raxo2222
Copy link
Contributor Author

This is very important so we can verify, that we won't get sound errors or pink units (multiple textures for multiple unit artstyles - we have 30 or so unit artstyles).

On other hand unused art/sound assets needlessly take memory - those should also be cleared up.

@raxo2222
Copy link
Contributor Author

raxo2222 commented Apr 21, 2021

#418
Seems like I forgot about it and made new issue.

Currently Text validator is under development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dll A C++ issue python A Python related issue xml Related to the XML data
Projects
Bugs and Asserts
  
Backlog
Development

No branches or pull requests

3 participants